Review main Merged

61376[TASK] Modify HTTP proxy description

Guido Schmechel CR +2 V +2 Easy +4 −1 updated 08/29/19, 14:52

Commit message

The configuration of an array for a http proxy will now
be described in more detail in the field description.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Guido Schmechel +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Guido Schmechel +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2027

Show 12 earlier messages
  1. Guido Schmechel uploaded patch set 1 07/26/19, 13:12

  2. TYPO3com voted on patch set 1 V +1 07/26/19, 13:24 Completed build in 11m 37s on Fri, 26 Jul, 03:24 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35334

  1. Oliver Klee commented on patch set 1 07/26/19, 14:06

    DefaultConfigurationDescription.yaml:573

    If this is HTML, should we link the URL and encode the quotes as "?
  2. Guido Schmechel uploaded patch set 2 07/26/19, 15:50

  3. Guido Schmechel commented on patch set 2 07/26/19, 15:51

    DefaultConfigurationDescription.yaml:573 Reply Unresolved

    I do not know if we need encoding. But i adapted the syntax to an existing multiline example.
  4. TYPO3com voted on patch set 2 V +1 07/26/19, 16:00 Completed build in 09m 53s on Fri, 26 Jul, 06:00 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35340

  5. Oliver Klee commented on patch set 3 07/26/19, 17:03

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V +1 07/26/19, 17:14 Completed build in 10m 55s on Fri, 26 Jul, 07:14 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35344

  7. Oliver Klee voted on patch set 3 CR +1 07/27/19, 10:36

  8. Jonas Eberle voted on patch set 3 V +1 07/27/19, 17:49

  9. Jonas Eberle voted on patch set 3 CR +1 07/27/19, 17:49

  10. Jörg Bösche voted on patch set 3 V +1 CR +1 08/01/19, 08:23

  11. Anja Leichsenring uploaded patch set 4 08/02/19, 08:25

  12. Anja Leichsenring commented on patch set 4 V +1 CR +1 08/02/19, 08:26

    I removed the link from the description, because there is no optical hint for something being a link text. Now it is in line with other descriptions just displaying the URL.
  13. TYPO3com voted on patch set 4 V -1 08/02/19, 08:41 Completed build in 15m 09s on Fri, 2 Aug, 08:41 AM Test Summary: 1 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35450

  14. TYPO3com voted on patch set 4 V +1 08/02/19, 09:48 Completed build in 1h 36m 58s on Fri, 2 Aug, 09:48 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35450

  15. Jonas Eberle commented on patch set 4 08/02/19, 09:53

    Please leave the link in there. Even though it is not a lot different from normal text right now, it is still a link and the visual problem could easily be solved in CSS.
  16. Anja Leichsenring uploaded patch set 5 08/02/19, 11:22

  17. Anja Leichsenring commented on patch set 5 08/02/19, 11:22

    done. No vote, though.
  18. TYPO3com voted on patch set 5 V +1 08/02/19, 11:31 Completed build in 09m 45s on Fri, 2 Aug, 11:31 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35456

  19. Jonas Eberle voted on patch set 5 V +1 CR +1 08/02/19, 12:14

  20. Frank Nägler uploaded patch set 6 08/29/19, 13:58

  21. Frank Nägler commented on patch set 6 V +1 CR +1 08/29/19, 13:58

    I have added rel="noopener noreferrer" to the links.
  22. Guido Schmechel voted on patch set 6 V +1 CR +1 08/29/19, 14:00

  23. TYPO3com voted on patch set 6 V +1 08/29/19, 14:07 Completed build in 09m 25s on Thu, 29 Aug, 02:07 PM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35926

  24. Andreas Kienast voted on patch set 6 V +2 CR +2 08/29/19, 14:52

  25. Andreas Kienast merged patch set 7 08/29/19, 14:52