Review main Merged

61377[TASK] Deprecate BackendUtility::editOnClick()

Andreas Kienast CR +2 V +2 Hard +142 −192 updated 07/29/19, 10:40

Commit message

This patch deprecates BackendUtility::editOnClick() which is used to build
a JavaScript-based redirect to the EditDocumentController for use in an
`onclick` attribute. This approach is not necessary anymore, thus all
links use a real `href` attriute now.

Also, this patch removes the following methods:
- TYPO3\CMS\Backend\View\PageLayoutView::linkWrapTable()
- TYPO3\CMS\Backend\View\PageLayoutView::linkWrapItems()
- TYPO3\CMS\Backend\View\PageLayoutView::newContentElementOnClick()

Reason is that these methods contain code that would need a migration, but
are unused in the whole Core. Since the class is marked as "internal",
it's considered safe to remove them.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Daniel Windloff +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Daniel Windloff +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 914

  1. Andreas Kienast uploaded patch set 1 07/26/19, 13:15

  2. Andreas Kienast uploaded patch set 2 07/26/19, 13:17

  3. TYPO3com voted on patch set 1 V -1 07/26/19, 13:20 Completed build in 05m 24s on Fri, 26 Jul, 03:20 PM Test Summary: 3 of 39994 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35335

  4. TYPO3com voted on patch set 2 V -1 07/26/19, 13:29 Completed build in 11m 37s on Fri, 26 Jul, 03:29 PM Test Summary: 17 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35336

  5. Andreas Kienast uploaded patch set 3 07/28/19, 08:07

  6. TYPO3com voted on patch set 3 V +1 07/28/19, 08:17 Completed build in 09m 55s on Sun, 28 Jul, 10:17 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35346

  7. Andreas Kienast uploaded patch set 4 07/28/19, 08:44

  8. TYPO3com voted on patch set 4 V +1 07/28/19, 08:55 Completed build in 11m 21s on Sun, 28 Jul, 10:55 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35347

  9. Andreas Kienast uploaded patch set 5 07/29/19, 07:05

  10. TYPO3com voted on patch set 5 V +1 07/29/19, 07:16 Completed build in 11m 16s on Mon, 29 Jul, 09:16 AM Test Summary: 47159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35352

  11. Daniel Windloff voted on patch set 5 V +1 CR +1 07/29/19, 08:10

  12. Georg Ringer voted on patch set 5 V +1 CR +1 07/29/19, 08:14

  13. Andreas Kienast voted on patch set 5 V +2 CR +2 07/29/19, 10:40

  14. Andreas Kienast merged patch set 6 07/29/19, 10:40