Review main Abandoned

61379[TASK] Sorting direction for XML sitemap records

Guido Schmechel CR 0 V 0 Easy +42 −2 updated 10/25/19, 21:54

Commit message

Add the ability to define the sorting direction of
XML sitemap records.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 1620

  1. Guido Schmechel uploaded patch set 1 07/26/19, 15:18

  2. TYPO3com voted on patch set 1 V -1 07/26/19, 15:30 Completed build in 11m 16s on Fri, 26 Jul, 05:30 PM Test Summary: 3 of 47522 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35338

  3. Guido Schmechel uploaded patch set 2 07/26/19, 15:38

  4. TYPO3com voted on patch set 2 V +1 07/26/19, 15:49 Completed build in 10m 57s on Fri, 26 Jul, 05:49 PM Test Summary: 47163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35339

  5. Guido Schmechel commented on patch set 2 07/26/19, 15:55

    To discuss: Is this a feature (v10 only) or a task (v10 and v9)? IMO we can add this as task to v9, too. If necessary, we just have to adapt the documentation for this new option: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/XmlSitemap/Index.html
  6. Guido Schmechel commented on patch set 2 07/26/19, 16:02

    XmlSitemapRecordsTest.php:178 Unresolved

    Very dirty test. I am open for a better test.
  7. Markus Klein commented on patch set 2 CR +1 07/31/19, 00:26

    looks good by reading
  8. Richard Haeser commented on patch set 2 08/21/19, 20:44

    See my comment in the forge issue.
  9. Guido Schmechel updated the commit message in patch set 3 08/27/19, 21:26

  10. TYPO3com voted on patch set 3 V +1 08/27/19, 21:38 Completed build in 12m 31s on Tue, 27 Aug, 09:38 PM Test Summary: 47230 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35868

  11. Markus Klein commented on patch set 3 08/28/19, 07:15

    1.) This is actually wrong: We added the "sorting direction", sorting by a specified fields works already. 2.) The wording is wrong. Commit messages must be imperative present. "Add the ability to..."
  12. Markus Klein updated the commit message in patch set 4 08/28/19, 07:16

  13. TYPO3com voted on patch set 4 V +1 08/28/19, 07:27 Completed build in 10m 50s on Wed, 28 Aug, 07:27 AM Test Summary: 47241 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35876

  14. Guido Schmechel commented on patch set 4 08/28/19, 08:12

    Reply Unresolved

    Thanks for your corrections!
  15. Markus Klein voted on patch set 4 V +1 CR +1 08/28/19, 09:16

  16. Oliver Klee commented on patch set 4 08/28/19, 09:17

    Unresolved

    Isn't this more of a [FEATURE] then?

    tt_content.xml:17 Unresolved

    For consistency, please use the same indentation as there is in the rest of the file (i.e., tabs).

    XmlSitemapRecordsTest.php:160 Unresolved

    Generally, test names should be a sentence with a statement (unlike other methods names, which should start with a verb). In addition, please don't use "correctly" in test names as the reade then still does not know what behavior is the correct one (by reading the test name only). This slide from one of my workshops might be helpful: https://speakerdeck.com/oliverklee/test-driven-development-with-phpunit-1?slide=49 So, in this case, I propose changing the name to "recordsAreSortedCorrectlyByUidInAscendingOrder" (if that's what the correct sorting should be)
  17. Richard Haeser commented on patch set 4 08/28/19, 10:46

    See also my comment on the ticket. I'm still not in favour of adding this option to the XML sitemaps because it will make it possible to change every page in your XML sitemap when you edit a page and that can have possible negative effects. Besides that, I think this feature shouldn't be mixed up RSS and XML sitemap because if for some reason we need to make choices especially for XML sitemaps, it is hard to keep track of all the other use-cases this feature is used for. Maybe we should refactor some code to make a global part (uses by XML sitemap and RSS) and a specific part for SEO and for RSS. For example the whole index / sitemaps part is something you don't need in RSS.
  18. Markus Klein commented on patch set 4 V 0 CR 0 08/28/19, 12:12

    Okay, reverting my votes and I'll stay neutral then.
  19. Guido Schmechel commented on patch set 4 08/28/19, 14:32

    I am open to a more global approach. Feel free to abandon.
  20. Susi Moog abandoned the change 10/25/19, 21:54

    Abandoned in favor of a more global approach.