61380[BUGFIX] Prevent InvalidArgumentException
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1213
-
Guido Schmechel uploaded patch set 1 07/26/19, 16:08
-
TYPO3com voted on patch set 1 V +1 07/26/19, 16:19 Completed build in 10m 42s on Fri, 26 Jul, 06:19 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35341
-
Mathias Brodala commented on patch set 1 V -1 07/29/19, 07:29
I cannot see an error with PHP 7.3.7, not even without this change. -
Andreas Kienast commented on patch set 1 07/29/19, 07:36
@Mathias: This highly depends on the installed PCRE version _and_ the PHP version. Some older PHP 7.3 installations are affected, I had that some months ago, too, but fail to reproduce such issues with the latest 7.3.7. -
Oliver Klee voted on patch set 1 CR +1 07/29/19, 08:16
-
Anja Leichsenring commented on patch set 1 CR +1 08/24/19, 16:59
I'd say the escaping will not hurt, even if the error never occurred again. Opinions? -
Oliver Klee commented on patch set 1 08/25/19, 10:28
> I'd say the escaping will not hurt, even if the error never occurred again. I agree. -
Daniel Goerz commented on patch set 1 08/30/19, 08:10
According to https://github.com/TYPO3/Fluid/issues/449 there are more places affected, right (cant reproduce it myself) -
Andreas Kienast commented on patch set 1 CR -1 08/30/19, 08:12
Claus aimed to release a new Fluid version soon which claims to fix these escaping bugs. I'd say lets wait for the release and check whether the issue still occurs. -
Anja Leichsenring wrote 09/09/19, 08:44
Removed reviewer Anja Leichsenring with the following votes: * Code-Review+1 by Anja Leichsenring <aleichsenring@ab-softlab.de> -
Susi Moog commented on patch set 1 10/26/19, 08:04
Is this issue still reproducible? We are not able to reproduce this currently and I'm unsure on whether "something" fixed it in the meantime. -
Mathias Brodala commented on patch set 1 11/23/19, 22:00
> Patch Set 1: > > Is this issue still reproducible? We are not able to reproduce this currently and I'm unsure on whether "something" fixed it in the meantime. As mentioned in the related Fluid ticket this highly depends on the environment. -
Susi Moog abandoned the change 01/15/20, 14:14