Review main Merged

61384[TASK] Deprecate sending mails in ContentObjectRenderer

Georg Ringer CR +2 V +2 Normal +112 −1 updated 08/02/19, 12:39

Commit message

The ContentObjectRenderer should not care about sending mails, therefore it has
been marked as deprecated.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2431

Show 56 earlier messages
  1. Georg Ringer uploaded patch set 1 07/29/19, 07:13

  2. Georg Ringer commented on patch set 1 07/29/19, 07:14

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 07/29/19, 07:23 Completed build in 10m 02s on Mon, 29 Jul, 09:23 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35353

  4. Oliver Klee commented on patch set 1 07/29/19, 08:18

    FrontendLoginController.php:1051 Unresolved

    AS this method is new (here), can we have parameter type hints?

    FrontendLoginController.php:1066 Unresolved

    I propose we make this a guard clause and move it to the beginning of the method.
  5. Andreas Kienast commented on patch set 1 CR -1 07/29/19, 10:15

    on it
  6. Andreas Kienast uploaded patch set 2 07/29/19, 10:18

  1. Andreas Kienast voted on patch set 2 V +1 CR +1 07/29/19, 10:18

  2. Georg Ringer commented on patch set 2 07/29/19, 10:22

    FrontendLoginController.php:519

    a typecast is now required I guess as e.g. replyTo could also be not set?
  3. TYPO3com voted on patch set 2 V +1 07/29/19, 10:28 Completed build in 10m 23s on Mon, 29 Jul, 12:28 PM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35357

  4. Andreas Kienast commented on patch set 2 CR -1 07/29/19, 10:41

    FrontendLoginController.php:519 Reply

    Ack
  5. Andreas Kienast uploaded patch set 3 07/29/19, 10:43

  6. Andreas Kienast uploaded patch set 4 07/29/19, 10:44

  7. Oliver Klee commented on patch set 5 07/29/19, 10:56

    Published edit on patch set 4.
  8. Andreas Kienast commented on patch set 5 07/29/19, 10:57

    FrontendLoginController.php:1071

    Why rather call trim() two times now?
  9. TYPO3com voted on patch set 4 V -1 07/29/19, 11:04 Completed build in 14m 32s on Mon, 29 Jul, 01:04 PM Test Summary: 5 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35360

  10. Oliver Klee commented on patch set 5 07/29/19, 11:06

    FrontendLoginController.php:1071 Reply Unresolved

    Because the parameter $message would be overwritten otherwise, and overwriting parameters is bad practice (as it can become very confusing). I could introduce a different variable instead, if you like.
  11. TYPO3com voted on patch set 5 V +1 07/29/19, 11:12 Completed build in 13m 31s on Mon, 29 Jul, 01:12 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35362

  12. Georg Ringer commented on patch set 5 07/30/19, 06:01

    TBH I just would go with my 1st patch, the code of felogin will be refactored anyway ....
  13. Andreas Kienast commented on patch set 5 07/30/19, 06:27

    > Patch Set 5: > > TBH I just would go with my 1st patch, the code of felogin will be refactored anyway .... It's your patch, do whatever you want.
  14. Georg Ringer uploaded patch set 6 08/02/19, 11:44

  15. Oliver Klee voted on patch set 6 CR +1 08/02/19, 11:52

  16. Anja Leichsenring commented on patch set 7 08/02/19, 11:53

    Published edit on patch set 6.
  17. Anja Leichsenring voted on patch set 7 V +1 CR +1 08/02/19, 11:54

  18. TYPO3com voted on patch set 6 V +1 08/02/19, 11:55 Completed build in 10m 53s on Fri, 2 Aug, 11:55 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35460

  19. Markus Klein commented on patch set 7 08/02/19, 12:01

    Deprecation-88850-ContentObjectRendererSendNotifyEmail.rst:35 Unresolved

    really this address, not a dummy?
  20. TYPO3com voted on patch set 7 V +1 08/02/19, 12:03 Completed build in 09m 43s on Fri, 2 Aug, 12:03 PM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35461

  21. Josef Glatz uploaded patch set 8 08/02/19, 12:26

  22. Josef Glatz voted on patch set 8 V +1 CR +1 08/02/19, 12:27

  23. TYPO3com voted on patch set 8 V +1 08/02/19, 12:37 Completed build in 10m 34s on Fri, 2 Aug, 12:37 PM Test Summary: 47163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35465

  24. Anja Leichsenring voted on patch set 8 V +2 CR +2 08/02/19, 12:38

  25. Anja Leichsenring merged patch set 9 08/02/19, 12:39