61385[TASK] Deprecate T3_THIS_LOCATION
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Björn Jacob +1
- Frank Nägler +1
-
Verified V +2 Done
- Georg Ringer +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+1 −0
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-88854-JumpExtOfRecordListController.rstnew+34 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-88854-T3_THIS_LOCATION.rst4new+41 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Be/TableListViewHelper.php+1 −1
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −0
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php4+23 −23
Review log 1723
-
Andreas Kienast uploaded patch set 1 07/29/19, 15:58
-
TYPO3com voted on patch set 1 V +1 07/29/19, 16:10 Completed build in 11m 01s on Mon, 29 Jul, 06:10 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35369
-
Björn Jacob commented on patch set 1 07/29/19, 18:19
Deprecation-88854-T3_THIS_LOCATION.rst:35Should this start with a lowercase char? -
Andreas Kienast commented on patch set 1 07/29/19, 18:28
Deprecation-88854-T3_THIS_LOCATION.rst:22ReplyAckDeprecation-88854-T3_THIS_LOCATION.rst:35Reply UnresolvedI refer to the class name, but I will update this -
Andreas Kienast commented on patch set 1 CR -1 07/29/19, 18:30
on it -
Andreas Kienast uploaded patch set 2 07/29/19, 18:38
-
TYPO3com voted on patch set 2 V +1 07/29/19, 18:49 Completed build in 11m 03s on Mon, 29 Jul, 08:49 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35370
-
Björn Jacob voted on patch set 2 CR +1 07/29/19, 19:38
-
Daniel Windloff commented on patch set 2 07/30/19, 07:59
DatabaseRecordList.php:638It was DatabaseRecordList->listURL()DatabaseRecordList.php:1473Unresolvedsame hereDatabaseRecordList.php:1563Unresolvedsame here -
Andreas Kienast commented on patch set 2 07/30/19, 12:16
DatabaseRecordList.php:638Reply UnresolvedI fail to spot any functional difference in the result. I also spotted the method `makeReturnUrl()` which also uses REQUEST_URI. -
Andreas Kienast uploaded patch set 3 07/30/19, 12:50
-
TYPO3com voted on patch set 3 V +1 07/30/19, 13:04 Completed build in 14m 04s on Tue, 30 Jul, 01:04 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35383
-
Björn Jacob voted on patch set 3 CR +1 07/30/19, 13:25
-
Andreas Kienast uploaded patch set 4 07/30/19, 13:57
-
TYPO3com voted on patch set 4 V +1 07/30/19, 14:08 Completed build in 10m 35s on Tue, 30 Jul, 02:08 PM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35389
-
Andreas Kienast uploaded patch set 5 07/30/19, 14:14
-
Andreas Kienast uploaded patch set 6 07/30/19, 14:21
-
Frank Nägler voted on patch set 6 V +1 CR +1 07/30/19, 14:25
-
Björn Jacob voted on patch set 6 CR +1 07/30/19, 14:27
-
TYPO3com voted on patch set 5 V +1 07/30/19, 14:28 Completed build in 13m 46s on Tue, 30 Jul, 02:28 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35391
-
TYPO3com voted on patch set 6 V +1 07/30/19, 14:33 Completed build in 12m 04s on Tue, 30 Jul, 02:33 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35392
-
Georg Ringer voted on patch set 6 V +2 CR +2 07/31/19, 13:59
-
Georg Ringer merged patch set 7 07/31/19, 13:59
Deprecation-88854-T3_THIS_LOCATION.rst:22