Review main Merged

61385[TASK] Deprecate T3_THIS_LOCATION

Andreas Kienast CR +2 V +2 Normal +103 −24 updated 07/31/19, 13:59

Commit message

This patch deprecates the global variable `T3_THIS_LOCATION`. This
variable is mostly used to attach a returnUrl argument to links,
triggered via a redirect on an onclick event.

In most cases this is not necessary anymore, also it's considered bad
practice not to use regular links in an href attribute.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Björn Jacob +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1723

  1. Andreas Kienast uploaded patch set 1 07/29/19, 15:58

  2. TYPO3com voted on patch set 1 V +1 07/29/19, 16:10 Completed build in 11m 01s on Mon, 29 Jul, 06:10 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35369

  3. Björn Jacob commented on patch set 1 07/29/19, 18:19

    Deprecation-88854-T3_THIS_LOCATION.rst:22

    Superfluous, isn't it?

    Deprecation-88854-T3_THIS_LOCATION.rst:35

    Should this start with a lowercase char?
  4. Andreas Kienast commented on patch set 1 07/29/19, 18:28

    Deprecation-88854-T3_THIS_LOCATION.rst:22 Reply

    Ack

    Deprecation-88854-T3_THIS_LOCATION.rst:35 Reply Unresolved

    I refer to the class name, but I will update this
  5. Andreas Kienast commented on patch set 1 CR -1 07/29/19, 18:30

    on it
  6. Andreas Kienast uploaded patch set 2 07/29/19, 18:38

  7. TYPO3com voted on patch set 2 V +1 07/29/19, 18:49 Completed build in 11m 03s on Mon, 29 Jul, 08:49 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35370

  8. Björn Jacob voted on patch set 2 CR +1 07/29/19, 19:38

  9. Daniel Windloff commented on patch set 2 07/30/19, 07:59

    DatabaseRecordList.php:638

    It was DatabaseRecordList->listURL()

    DatabaseRecordList.php:1473 Unresolved

    same here

    DatabaseRecordList.php:1563 Unresolved

    same here
  10. Andreas Kienast commented on patch set 2 07/30/19, 12:16

    DatabaseRecordList.php:638 Reply Unresolved

    I fail to spot any functional difference in the result. I also spotted the method `makeReturnUrl()` which also uses REQUEST_URI.
  11. Andreas Kienast uploaded patch set 3 07/30/19, 12:50

  12. TYPO3com voted on patch set 3 V +1 07/30/19, 13:04 Completed build in 14m 04s on Tue, 30 Jul, 01:04 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35383

  13. Björn Jacob voted on patch set 3 CR +1 07/30/19, 13:25

  14. Andreas Kienast uploaded patch set 4 07/30/19, 13:57

  15. TYPO3com voted on patch set 4 V +1 07/30/19, 14:08 Completed build in 10m 35s on Tue, 30 Jul, 02:08 PM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35389

  16. Andreas Kienast uploaded patch set 5 07/30/19, 14:14

  17. Andreas Kienast uploaded patch set 6 07/30/19, 14:21

  18. Frank Nägler voted on patch set 6 V +1 CR +1 07/30/19, 14:25

  19. Björn Jacob voted on patch set 6 CR +1 07/30/19, 14:27

  20. TYPO3com voted on patch set 5 V +1 07/30/19, 14:28 Completed build in 13m 46s on Tue, 30 Jul, 02:28 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35391

  21. TYPO3com voted on patch set 6 V +1 07/30/19, 14:33 Completed build in 12m 04s on Tue, 30 Jul, 02:33 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35392

  22. Georg Ringer voted on patch set 6 V +2 CR +2 07/31/19, 13:59

  23. Georg Ringer merged patch set 7 07/31/19, 13:59