Review main Merged

61388[TASK] Drop JavaScript function `jumpSelf`

Andreas Kienast CR +2 V +2 Easy +20 −26 updated 07/30/19, 12:35

Commit message

The JavaScript function `jumpSelf` is only used to some clipboard actions.
Moving the links to a regular `href` has the same effect, rendering this
very function useless.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jonas Eberle +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jonas Eberle +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Andreas Kienast uploaded patch set 1 07/29/19, 19:17

  2. TYPO3com voted on patch set 1 V +1 07/29/19, 19:28 Completed build in 11m 02s on Mon, 29 Jul, 09:28 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35375

  3. Jonas Eberle commented on patch set 1 V +1 CR +1 07/29/19, 19:30

    Tested with Firefox only but I see no reason why this should make problems in other browsers.
  4. Daniel Windloff commented on patch set 1 07/30/19, 07:44

    DatabaseRecordList.php:2144

    Set the return url
  5. Andreas Kienast commented on patch set 1 07/30/19, 07:48

    DatabaseRecordList.php:2144 Reply Unresolved

    Thanks, good catch!
  6. Andreas Kienast commented on patch set 2 07/30/19, 07:48

    Published edit on patch set 1.
  7. TYPO3com voted on patch set 2 V +1 07/30/19, 07:59 Completed build in 10m 39s on Tue, 30 Jul, 09:59 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35380

  8. Frank Nägler voted on patch set 2 CR +1 07/30/19, 12:24

  9. Frank Nägler voted on patch set 2 V +1 07/30/19, 12:25

  10. Jonas Eberle voted on patch set 2 V +1 CR +1 07/30/19, 12:26

  11. Andreas Kienast voted on patch set 2 V +2 CR +2 07/30/19, 12:35

  12. Andreas Kienast merged patch set 3 07/30/19, 12:35