Review main Merged

61389[TASK] Deprecate jumpToUrl()

Andreas Kienast CR +2 V +2 Normal +60 −127 updated 09/04/19, 07:47

Commit message

This patch deprecated the well-known `jumpToUrl()` function which simply
does a redirect nowadays. Any occurence may be replaced by either using
`window.location.href` or using simple `<a>` tags.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Susi Moog +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1423

  1. Andreas Kienast uploaded patch set 1 07/29/19, 19:44

  2. TYPO3com voted on patch set 1 V +1 07/29/19, 19:54 Completed build in 10m 38s on Mon, 29 Jul, 09:54 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35376

  3. Andreas Kienast uploaded patch set 2 07/30/19, 07:09

  4. TYPO3com voted on patch set 2 V +1 07/30/19, 07:19 Completed build in 09m 49s on Tue, 30 Jul, 09:19 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35377

  5. Andreas Kienast uploaded patch set 3 07/30/19, 12:55

  6. TYPO3com voted on patch set 3 V +1 07/30/19, 13:08 Completed build in 11m 55s on Tue, 30 Jul, 01:08 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35384

  7. Andreas Kienast uploaded patch set 4 07/31/19, 14:46

  8. TYPO3com voted on patch set 4 V +1 07/31/19, 14:56 Completed build in 10m 03s on Wed, 31 Jul, 02:56 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35419

  9. Andreas Kienast uploaded patch set 5 08/28/19, 13:53

  10. Andreas Kienast uploaded patch set 6 08/28/19, 14:10

  11. TYPO3com voted on patch set 5 V -1 08/28/19, 14:10 Completed build in 11m 28s on Wed, 28 Aug, 02:10 PM Test Summary: 47238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35892

  12. TYPO3com voted on patch set 6 V -1 08/28/19, 14:22 Completed build in 12m 21s on Wed, 28 Aug, 02:22 PM Test Summary: 1 of 47597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35893

  13. Benni Mack commented on patch set 6 08/28/19, 14:29

    RecordListController.php:381

    copy/paste error. the method is "jumpExt()"... is wrong
  14. TYPO3com voted on patch set 6 V +1 08/28/19, 14:29 Completed build in 31m 05s on Wed, 28 Aug, 02:29 PM Test Summary: 47238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35893

  15. Andreas Kienast commented on patch set 6 08/28/19, 14:32

    RecordListController.php:381 Reply

    Ack
  16. Andreas Kienast uploaded patch set 7 08/28/19, 14:33

  17. TYPO3com voted on patch set 7 V +1 08/28/19, 14:44 Completed build in 10m 25s on Wed, 28 Aug, 02:44 PM Test Summary: 47238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35896

  18. Andreas Kienast uploaded patch set 8 08/29/19, 14:57

  19. TYPO3com voted on patch set 8 V +1 08/29/19, 15:15 Completed build in 17m 54s on Thu, 29 Aug, 03:15 PM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35934

  20. Daniel Goerz voted on patch set 8 CR +1 08/30/19, 10:58

  21. Richard Haeser voted on patch set 8 V +1 CR +1 09/02/19, 21:04

  22. Susi Moog voted on patch set 8 V +2 CR +2 09/04/19, 07:47

  23. Susi Moog merged patch set 9 09/04/19, 07:47