61392[BUGFIX] Strip logical operator prefix in config.additionalWhere
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- Richard Haeser +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 2128
Show 23 earlier messages
-
Rémy DANIEL uploaded patch set 1 07/30/19, 16:01
-
Rémy DANIEL updated the commit message in patch set 2 07/30/19, 16:03
-
TYPO3com voted on patch set 1 V +1 07/30/19, 16:13 Completed build in 12m 02s on Tue, 30 Jul, 04:13 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35394
-
TYPO3com voted on patch set 2 V +1 07/30/19, 16:15 Completed build in 11m 54s on Tue, 30 Jul, 04:15 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35395
-
Tymoteusz Motylewski commented on patch set 2 07/30/19, 22:28
Are you able to add a test for it? -
Anja Leichsenring voted on patch set 2 V +1 CR +1 08/02/19, 11:52
-
Guido Schmechel commented on patch set 2 CR -1 08/02/19, 12:26
I will have a look for a test -
Andreas Kienast commented on patch set 2 08/08/19, 11:22
> Patch Set 2: Code-Review-1 > > I will have a look for a test ping -
Guido Schmechel wrote 08/08/19, 12:57
Removed Code-Review-1 by Guido Schmechel <guido.schmechel@brandung.de> -
Guido Schmechel commented on patch set 2 V +1 CR +1 08/08/19, 13:01
I could not quickly produce good tests, e.g. just check the constraints. Functional tests did not seem conclusive. Richdard may be able to look in general here, as here is still a ticket is open: https://forge.typo3.org/issues/86061 The given functionality works of course. -
Richard Haeser uploaded patch set 3 08/21/19, 19:38
-
Richard Haeser commented on patch set 3 08/21/19, 19:38
Thanks a lot for this patch. Added some functional tests to check different TypoScript configurations. -
TYPO3com voted on patch set 3 V +1 08/21/19, 19:50 Completed build in 11m 55s on Wed, 21 Aug, 07:50 PM Test Summary: 47220 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35759
-
Markus Klein updated the commit message in patch set 4 08/21/19, 19:56
-
Anja Leichsenring commented on patch set 3 CR -1 08/21/19, 19:56
I guess a copy&paste error happened here?records.typoscript:52the naming is confusing. There is still only the AND as suffix, so what exactly do you expect to be stripped here and how does this condition provide other expectations than the previous one (without the OR)?XmlSitemapRecordsTest.php:217this should be id=3 according to the typoscript config -
Anja Leichsenring commented on patch set 4 CR -1 08/21/19, 19:57
see my comments on PS 3 -
Richard Haeser commented on patch set 4 08/21/19, 19:57
on it! -
Richard Haeser commented on patch set 4 CR -1 08/21/19, 20:03
records.typoscript:52Reply UnresolvedYou're right. Not the right name and I'm only checking the doctrine stuff now, so will remove this particular testcase.XmlSitemapRecordsTest.php:217Reply UnresolvedWill remove this one (see my reply on your other comment) -
TYPO3com voted on patch set 4 V +1 08/21/19, 20:06 Completed build in 10m 17s on Wed, 21 Aug, 08:06 PM Test Summary: 47220 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35760
-
Richard Haeser uploaded patch set 5 08/21/19, 20:11
-
TYPO3com voted on patch set 5 V -1 08/21/19, 20:22 Completed build in 10m 29s on Wed, 21 Aug, 08:22 PM Test Summary: 1 of 47576 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35761
-
TYPO3com voted on patch set 5 V +1 08/21/19, 20:37 Completed build in 10m 09s on Wed, 21 Aug, 08:37 PM Test Summary: 47217 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35762
-
Oliver Klee commented on patch set 5 08/22/19, 11:55
XmlSitemapRecordsTest.php:197UnresolvedIt's even array[]. -
Richard Haeser uploaded patch set 6 08/22/19, 12:16
-
TYPO3com voted on patch set 6 V +1 08/22/19, 12:28 Completed build in 12m 12s on Thu, 22 Aug, 12:28 PM Test Summary: 47217 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35764
-
Richard Haeser voted on patch set 6 V +1 CR +1 09/02/19, 07:02
-
Tymoteusz Motylewski voted on patch set 6 V +2 CR +2 09/02/19, 20:21
-
Tymoteusz Motylewski merged patch set 7 09/02/19, 20:22