61393[BUGFIX] Make redis pconnect calls unique
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Frank Nägler +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1317
-
Markus Klein uploaded patch set 1 07/31/19, 00:07
-
Markus Klein updated the commit message in patch set 2 07/31/19, 00:09
-
TYPO3com voted on patch set 1 V +1 07/31/19, 00:19 Completed build in 11m 46s on Wed, 31 Jul, 12:19 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35396
-
Markus Klein uploaded patch set 3 07/31/19, 00:21
-
TYPO3com voted on patch set 2 V +1 07/31/19, 00:21 Completed build in 12m 17s on Wed, 31 Jul, 12:21 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35397
-
TYPO3com voted on patch set 3 V +1 07/31/19, 00:32 Completed build in 10m 49s on Wed, 31 Jul, 12:32 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35398
-
Jonas Eberle commented on patch set 3 V +1 CR +1 07/31/19, 12:28
Tested with PHP 7.3 and ext-redis 4.3.0. I have 2 Redis instances and use different databases: TYPO3_CONF_VARS__SYS__session__BE__backend=TYPO3\CMS\Core\Session\Backend\RedisSessionBackend TYPO3_CONF_VARS__SYS__session__BE__options__hostname=redis TYPO3_CONF_VARS__SYS__session__BE__options__database=0 TYPO3_CONF_VARS__SYS__session__FE__backend=TYPO3\CMS\Core\Session\Backend\RedisSessionBackend TYPO3_CONF_VARS__SYS__session__FE__options__hostname=redis TYPO3_CONF_VARS__SYS__session__FE__options__database=1 TYPO3_CONF_VARS__SYS__caching__cacheConfigurations__cache_hash__backend=TYPO3\CMS\Core\Cache\Backend\RedisBackend TYPO3_CONF_VARS__SYS__caching__cacheConfigurations__cache_hash__options__hostname=redis2 TYPO3_CONF_VARS__SYS__caching__cacheConfigurations__cache_hash__options__database=3 ... -> I can confirm that entries are made on the correct instance and with the correct database. I was able to reproduce the bug with FE/BE sessions and this fixes it. Thank you! -
Andreas Kienast voted on patch set 3 CR +1 07/31/19, 13:49
-
Frank Nägler commented on patch set 3 CR -1 08/06/19, 13:48
RedisBackend.php:158Unresolved$this->database is an integer, but the pconnect method is annotated to expect a string value. The method has no type hint, but to be future ready, I would add a string cast here to ensure a string and to be consistent. -
Frank Nägler commented on patch set 4 08/06/19, 13:52
Published edit on patch set 3. -
Frank Nägler voted on patch set 4 V +1 CR +1 08/06/19, 13:54
-
TYPO3com voted on patch set 4 V +1 08/06/19, 14:03 Completed build in 10m 32s on Tue, 6 Aug, 02:03 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35614
-
Oliver Klee voted on patch set 4 CR +1 08/06/19, 15:12
-
Andreas Kienast voted on patch set 4 CR +1 08/07/19, 10:01
-
Frank Nägler voted on patch set 4 V +2 CR +2 08/07/19, 10:29
-
Andreas Kienast voted on patch set 4 V +1 08/07/19, 10:29
-
Frank Nägler merged patch set 5 08/07/19, 10:29