Review main Merged

61407[FEATURE] Allow array of handlers in RequestFactory

Frank Nägler CR +2 V +2 Easy +42 −0 updated 08/23/19, 13:40

Commit message

Guzzle has the possibility to push custom middleware handlers during
client initialization. With this patch it is now possible to define own
handlers as an array of callables in $GLOBALS['TYPO3_CONF_VARS']['HTTP']['handler'].
The RequestFactory builds a HandlerStack from that array
and injects it into the created client.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2231

Show 46 earlier messages
  1. Frank Nägler uploaded patch set 1 08/02/19, 19:19

  2. TYPO3com voted on patch set 1 V +1 08/02/19, 19:30 Completed build in 11m 10s on Fri, 2 Aug, 07:30 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35490

  3. Mathias Schreiber commented on patch set 1 CR -1 08/02/19, 19:43

    RequestFactory.php:52

    This line is way too long.

    DefaultConfiguration.php:1326 Unresolved

    should be callables
  4. Frank Nägler commented on patch set 1 08/02/19, 19:46

    RequestFactory.php:52 Reply Unresolved

    line 50 is longer
  5. Mathias Schreiber uploaded patch set 2 08/02/19, 19:46

  6. TYPO3com voted on patch set 2 V +1 08/02/19, 19:57 Completed build in 10m 30s on Fri, 2 Aug, 07:57 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35493

  1. Frank Nägler voted on patch set 2 CR -2 08/02/19, 20:09

  2. Frank Nägler voted on patch set 2 CR 0 08/02/19, 20:30

  3. Frank Nägler commented on patch set 2 08/02/19, 20:32

    A Demo Extension is available on GitHub: https://github.com/JBlocks/t3guzzlelog
  4. Jörg Bösche updated the commit message in patch set 3 08/02/19, 20:38

  5. TYPO3com voted on patch set 3 V -1 08/02/19, 20:49 Completed build in 10m 46s on Fri, 2 Aug, 08:49 PM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35495

  6. TYPO3com voted on patch set 3 V +1 08/02/19, 20:55 Completed build in 27m 48s on Fri, 2 Aug, 08:55 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35495

  7. Jörg Bösche voted on patch set 3 V +1 CR +1 08/02/19, 21:32

  8. Daniel Goerz voted on patch set 3 CR +1 08/02/19, 21:42

  9. Björn Jacob commented on patch set 3 08/03/19, 05:45

    Unresolved

    This needs some improvement. Either: "Guzzle has the possibility to push a custom middleware handler" or: "Guzzle has the possibility to push custom middleware handlers"

    Unresolved

    "The RequestFactory builds a correct HandlerStack and injects it to the created client."
  10. Georg Ringer uploaded patch set 4 08/03/19, 08:05

  11. Georg Ringer voted on patch set 4 V +1 CR +1 08/03/19, 08:06

  12. TYPO3com voted on patch set 4 V -1 08/03/19, 08:16 Completed build in 10m 49s on Sat, 3 Aug, 08:16 AM Test Summary: 21 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35529

  13. TYPO3com voted on patch set 4 V +1 08/03/19, 09:25 Completed build in 11m 16s on Sat, 3 Aug, 09:25 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35536

  14. Jörg Bösche voted on patch set 4 V +1 CR +1 08/03/19, 10:03

  15. Susi Moog commented on patch set 4 08/03/19, 10:07

    hmm. unsure about 8.7 and whether or not we would declare this as a feature.
  16. Susi Moog commented on patch set 4 CR -1 08/03/19, 10:37

    After discussing we decided that this is a feature, as Guzzle itself does not allow arrays but we enable our integration to do that now.
  17. Frank Nägler uploaded patch set 5 08/03/19, 12:41

  18. TYPO3com voted on patch set 5 V +1 08/03/19, 12:52 Completed build in 11m 11s on Sat, 3 Aug, 12:52 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35541

  19. Daniel Goerz commented on patch set 6 08/03/19, 13:09

    Published edit on patch set 5.
  20. TYPO3com voted on patch set 6 V +1 08/03/19, 13:23 Completed build in 14m 02s on Sat, 3 Aug, 01:23 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35545

  21. Susi Moog updated the commit message in patch set 7 08/04/19, 09:43

  22. TYPO3com voted on patch set 7 V +1 08/04/19, 09:52 Completed build in 09m 17s on Sun, 4 Aug, 09:52 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35570

  23. Andreas Kienast voted on patch set 7 V +1 CR +1 08/08/19, 07:38

  24. Anja Leichsenring voted on patch set 7 V +2 CR +2 08/23/19, 13:40

  25. Anja Leichsenring merged patch set 8 08/23/19, 13:40