Review main Merged

61408[BUGFIX] Ensure all files in a directory are deleted

Georg Großberger CR +2 V +2 Easy +13 −3 updated 08/03/19, 13:09

Commit message

The function readdir may skip files inside a directory when
its content is changed, like a file being deleted. This can
cause not all files inside being deleted

To avoid this, we collect all entries inside a directory and
close the read descriptor before deleting all entries inside.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Marc von Schalscha +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Susi Moog +2
    • Marco Bresch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Großberger uploaded patch set 1 08/02/19, 19:28

  2. TYPO3com voted on patch set 1 V +1 08/02/19, 19:38 Completed build in 09m 56s on Fri, 2 Aug, 07:38 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35491

  3. Matthias Vogel voted on patch set 1 CR +1 08/02/19, 19:43

  4. Marc von Schalscha commented on patch set 1 CR +1 08/02/19, 19:54

    Should do the job.
  5. Marco Bresch commented on patch set 1 V +1 08/02/19, 22:34

    Deleting an extension including more than 2000 files are deleted
  6. Susi Moog voted on patch set 1 CR +1 08/03/19, 10:15

  7. Susi Moog voted on patch set 1 V +2 CR +2 08/03/19, 13:09

  8. Susi Moog merged patch set 2 08/03/19, 13:09