61416[BUGFIX] Respect columnsOverrides in TCA for all field types
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Susi Moog +1
-
Verified V +2 Done
- Daniel Goerz +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/FormSlugAjaxController.php+8 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+23 −6
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/createPageWithSlugOverrideConfiguration.csvnew+7 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+33 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+1 −1
Review log 2839
Show 914 earlier messages
-
Benjamin Gries uploaded patch set 1 08/02/19, 21:14
-
TYPO3com voted on patch set 1 V -1 08/02/19, 21:38 Completed build in 15m 46s on Fri, 2 Aug, 09:38 PM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35507
-
Benjamin Gries uploaded patch set 2 08/02/19, 22:03
-
TYPO3com commented on patch set 2 08/02/19, 22:17 Completed build in 14m 44s on Fri, 2 Aug, 10:17 PM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35521
-
Benjamin Gries uploaded patch set 3 08/03/19, 12:48
-
TYPO3com voted on patch set 3 V +1 08/03/19, 12:59 Completed build in 10m 32s on Sat, 3 Aug, 12:59 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35542
-
Michael Blunck voted on patch set 3 V +1 CR +1 08/03/19, 19:02
-
Maik Hagenbruch voted on patch set 3 V +1 CR +1 08/03/19, 19:04
-
Maik Hagenbruch wrote 08/03/19, 19:05
Removed Verified+1 by Maik Hagenbruch <typo3@hagenbruch.info> -
Anja Leichsenring commented on patch set 3 08/04/19, 09:09
That is more a feature than a bugfix, and deserves a documentation file. -
Josef Glatz updated the commit message in patch set 4 08/04/19, 09:12
-
Josef Glatz updated the commit message in patch set 5 08/04/19, 09:13
-
TYPO3com voted on patch set 4 V -1 08/04/19, 09:24 Completed build in 11m 49s on Sun, 4 Aug, 09:24 AM Test Summary: 5 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35567
-
TYPO3com voted on patch set 5 V -1 08/04/19, 09:24 Completed build in 10m 58s on Sun, 4 Aug, 09:24 AM Test Summary: 5 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35568
-
Josef Glatz commented on patch set 5 CR -1 08/05/19, 04:14
I would also say that‘s a feature. Please add a RsT and adopt your commit message -
Benjamin Gries uploaded patch set 6 08/05/19, 07:49
-
Benjamin Gries uploaded patch set 7 08/05/19, 07:51
-
TYPO3com voted on patch set 6 V -1 08/05/19, 08:00 Completed build in 10m 54s on Mon, 5 Aug, 08:00 AM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35578
-
TYPO3com voted on patch set 7 V -1 08/05/19, 08:02 Completed build in 10m 47s on Mon, 5 Aug, 08:02 AM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35579
-
TYPO3com voted on patch set 7 V +1 08/05/19, 11:52 Completed build in 4h 11m 15s on Mon, 5 Aug, 11:52 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35579
-
Benjamin Gries commented on patch set 7 V -1 08/05/19, 12:00
Seems to be working for all records, but not newly created pages which are dragged into the page tree. -
Anja Leichsenring wrote 09/09/19, 13:34
Removed reviewer Anja Leichsenring. -
Daniel Goerz uploaded patch set 8 02/28/20, 14:40
-
Daniel Goerz commented on patch set 8 02/28/20, 14:45
I would very well argue that this is indeed a BUGFIX as the TCA override is just not working for the generatorOptions at the moment and it does work for the rest of the TCA columns configuration. -
TYPO3com voted on patch set 8 V +1 02/28/20, 14:59 Completed build in 17m 45s on Fri, 28 Feb, 02:59 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-795
-
Susi Moog commented on patch set 8 V +1 CR +1 02/28/20, 15:04
> Patch Set 8: > > I would very well argue that this is indeed a BUGFIX as the TCA override is just not working for the generatorOptions at the moment and it does work for the rest of the TCA columns configuration. I agree. -
Daniel Goerz voted on patch set 8 V +1 CR +1 02/28/20, 15:51
-
Daniel Goerz commented on patch set 8 CR -1 03/02/20, 08:34
Blocked until checked by Benni -
Susi Moog uploaded patch set 9 03/06/20, 08:50
-
TYPO3com voted on patch set 9 V +1 03/06/20, 09:01 Completed build in 10m 40s on Fri, 6 Mar, 09:01 AM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1010
-
Daniel Goerz voted on patch set 9 V +1 CR +1 03/06/20, 09:13
-
Susi Moog voted on patch set 9 V +1 CR +1 03/06/20, 10:26
-
Benni Mack commented on patch set 9 CR -1 03/06/20, 10:36
please wait on this -
Benni Mack uploaded patch set 10 03/06/20, 10:47
-
TYPO3com voted on patch set 10 V +1 03/06/20, 10:58 Completed build in 11m 39s on Fri, 6 Mar, 10:58 AM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1013
-
Susi Moog voted on patch set 10 CR +1 03/06/20, 11:11
-
Susi Moog voted on patch set 10 V +1 03/06/20, 14:24
-
Daniel Goerz commented on patch set 10 V +2 CR +2 03/15/20, 10:36
Verified with slug generation -
Daniel Goerz merged patch set 11 03/15/20, 10:36