Review main Merged

61417[BUGFIX] Removes cropping from pagetree title

Michael Blunck CR +2 V +2 Easy +0 −1 updated 08/03/19, 13:30

Commit message

Pagetree uses javascript for search.
Cropping causes issues because not the full title
is searched. As the pagetree is neither scrollable
nor resizable, cropping does not make sense anyway
and is therefor removed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Thomas Anders +1
    • Jörg Bösche +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Thomas Anders +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Michael Blunck uploaded patch set 1 08/02/19, 21:14

  2. Susi Moog voted on patch set 1 CR +1 08/02/19, 21:17

  3. TYPO3com voted on patch set 1 V -1 08/02/19, 21:40 Completed build in 17m 58s on Fri, 2 Aug, 09:40 PM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35509

  4. Thomas Anders commented on patch set 1 V +1 CR +1 08/02/19, 21:45

    Working. Tested with 165 letter title while filtering for the last letters. After Patching the page is found by the filter.
  5. TYPO3com voted on patch set 1 V +1 08/03/19, 09:35 Completed build in 12h 31m 14s on Sat, 3 Aug, 09:35 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35509

  6. Jörg Bösche voted on patch set 1 V +1 CR +1 08/03/19, 12:46

  7. Georg Ringer voted on patch set 1 V +2 CR +2 08/03/19, 13:30

  8. Georg Ringer merged patch set 2 08/03/19, 13:30