61418[FEATURE] Add api=1 option in VimeoRenderer
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Guido Schmechel +1
- Susi Moog +1
-
Verified V +2 Done
- Frank Nägler +2
- Guido Schmechel +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php+4 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-87525-AddApi1OptionInVimeoRenderer.rstnew+44 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+14 −0
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ContentElement.typoscript+1 −0
Review log 1422
-
Maik Hagenbruch uploaded patch set 1 08/02/19, 21:22
-
TYPO3com voted on patch set 1 V -1 08/02/19, 21:23 Completed build in 27s on Fri, 2 Aug, 09:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35511
-
Maik Hagenbruch updated the commit message in patch set 2 08/02/19, 21:25
-
TYPO3com voted on patch set 2 V -1 08/02/19, 21:36 Completed build in 47s on Fri, 2 Aug, 09:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35512
-
Maik Hagenbruch uploaded patch set 3 08/02/19, 21:38
-
TYPO3com voted on patch set 3 V -1 08/02/19, 21:38 Completed build in 23s on Fri, 2 Aug, 09:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35513
-
Andreas Kienast commented on patch set 3 08/02/19, 21:41
You may execute ./Build/Scripts/cglFixMyCommit.sh to fix the reported CGL issues. -
Maik Hagenbruch rebased onto patch set 4 08/02/19, 21:50
-
TYPO3com voted on patch set 4 V -1 08/02/19, 21:50 Completed build in 14s on Fri, 2 Aug, 09:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35517
-
Maik Hagenbruch uploaded patch set 5 08/02/19, 21:51
-
Maik Hagenbruch uploaded patch set 6 08/02/19, 21:58
-
TYPO3com voted on patch set 5 V -1 08/02/19, 22:04 Completed build in 12m 45s on Fri, 2 Aug, 10:04 PM Test Summary: 48 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35518
-
TYPO3com voted on patch set 6 V +1 08/02/19, 22:11 Completed build in 12m 03s on Fri, 2 Aug, 10:11 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35519
-
Guido Schmechel uploaded patch set 7 08/03/19, 08:03
-
TYPO3com voted on patch set 7 V +1 08/03/19, 08:14 Completed build in 10m 41s on Sat, 3 Aug, 08:14 AM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35528
-
Guido Schmechel commented on patch set 7 V +1 CR +1 08/03/19, 08:16
Just a simple test added. I have already successfully verified the change with the latest master. -
Susi Moog uploaded patch set 8 08/03/19, 13:04
-
Susi Moog commented on patch set 8 V +1 CR +1 08/03/19, 13:05
Updated the rst file with usage examples. -
TYPO3com voted on patch set 8 V +1 08/03/19, 13:15 Completed build in 11m 18s on Sat, 3 Aug, 01:15 PM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35544
-
Guido Schmechel voted on patch set 8 V +1 CR +1 08/03/19, 14:17
-
Frank Nägler voted on patch set 8 V +2 CR +2 08/23/19, 10:44
-
Frank Nägler merged patch set 9 08/23/19, 10:44