Review main Merged

61418[FEATURE] Add api=1 option in VimeoRenderer

Maik Hagenbruch CR +2 V +2 Normal +63 −1 updated 08/23/19, 10:44

Commit message

Adds option to add parameter "api=1" to vimeo video urls.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Guido Schmechel +1
    • Susi Moog +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Guido Schmechel +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1422

  1. Maik Hagenbruch uploaded patch set 1 08/02/19, 21:22

  2. TYPO3com voted on patch set 1 V -1 08/02/19, 21:23 Completed build in 27s on Fri, 2 Aug, 09:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35511

  3. Maik Hagenbruch updated the commit message in patch set 2 08/02/19, 21:25

  4. TYPO3com voted on patch set 2 V -1 08/02/19, 21:36 Completed build in 47s on Fri, 2 Aug, 09:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35512

  5. Maik Hagenbruch uploaded patch set 3 08/02/19, 21:38

  6. TYPO3com voted on patch set 3 V -1 08/02/19, 21:38 Completed build in 23s on Fri, 2 Aug, 09:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35513

  7. Andreas Kienast commented on patch set 3 08/02/19, 21:41

    You may execute ./Build/Scripts/cglFixMyCommit.sh to fix the reported CGL issues.
  8. Maik Hagenbruch rebased onto patch set 4 08/02/19, 21:50

  9. TYPO3com voted on patch set 4 V -1 08/02/19, 21:50 Completed build in 14s on Fri, 2 Aug, 09:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35517

  10. Maik Hagenbruch uploaded patch set 5 08/02/19, 21:51

  11. Maik Hagenbruch uploaded patch set 6 08/02/19, 21:58

  12. TYPO3com voted on patch set 5 V -1 08/02/19, 22:04 Completed build in 12m 45s on Fri, 2 Aug, 10:04 PM Test Summary: 48 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35518

  13. TYPO3com voted on patch set 6 V +1 08/02/19, 22:11 Completed build in 12m 03s on Fri, 2 Aug, 10:11 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35519

  14. Guido Schmechel uploaded patch set 7 08/03/19, 08:03

  15. TYPO3com voted on patch set 7 V +1 08/03/19, 08:14 Completed build in 10m 41s on Sat, 3 Aug, 08:14 AM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35528

  16. Guido Schmechel commented on patch set 7 V +1 CR +1 08/03/19, 08:16

    Just a simple test added. I have already successfully verified the change with the latest master.
  17. Susi Moog uploaded patch set 8 08/03/19, 13:04

  18. Susi Moog commented on patch set 8 V +1 CR +1 08/03/19, 13:05

    Updated the rst file with usage examples.
  19. TYPO3com voted on patch set 8 V +1 08/03/19, 13:15 Completed build in 11m 18s on Sat, 3 Aug, 01:15 PM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35544

  20. Guido Schmechel voted on patch set 8 V +1 CR +1 08/03/19, 14:17

  21. Frank Nägler voted on patch set 8 V +2 CR +2 08/23/19, 10:44

  22. Frank Nägler merged patch set 9 08/23/19, 10:44