Review main Merged

61419[BUGFIX] Allow sys_file_metadata to be translatable

Volker Kemeter CR +2 V +2 Normal +128 −22 updated 01/12/20, 14:54

Commit message

Since sys_file_metadata records are stored on pid=0,
there is no site configuration available. This situation is
similar to be_users.limitToLanguage feature, where
all languages of all sites need to be visible (depending
on the backend user rights).

This patch adds an option for the TranslationConfigurationProvider
to render all languages of all sites as a combined list
if the given pageId is 0 (based on the current user rights).

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1726

Show 1 earlier messages
  1. Volker Kemeter uploaded patch set 1 08/02/19, 21:40

  1. Volker Kemeter voted on patch set 1 V +1 CR +1 08/02/19, 21:42

  2. Volker Kemeter voted on patch set 1 V 0 CR 0 08/02/19, 21:43

  3. TYPO3com voted on patch set 1 V -1 08/02/19, 21:51 Completed build in 11m 10s on Fri, 2 Aug, 09:51 PM Test Summary: 5 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35515

  4. TYPO3com commented on patch set 1 08/02/19, 22:02 Completed build in 33m 13s on Fri, 2 Aug, 10:02 PM Test Summary: 5 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35515

  5. Guido Schmechel commented on patch set 1 08/02/19, 23:28

    Unresolved

    translatable
  6. Josef Glatz updated the commit message in patch set 2 08/03/19, 08:29

  7. TYPO3com voted on patch set 2 V +1 08/03/19, 08:44 Completed build in 14m 21s on Sat, 3 Aug, 08:44 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35532

  8. TYPO3com voted on patch set 2 V -1 08/03/19, 08:46 Completed build in 14m 26s on Sat, 3 Aug, 08:46 AM Test Summary: 21 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35534

  9. TYPO3com voted on patch set 2 V +1 08/03/19, 13:00 Completed build in 10m 30s on Sat, 3 Aug, 01:00 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35543

  10. Josef Glatz commented on patch set 2 V +1 CR +1 08/03/19, 13:28

    Works! There is one point missing, but we can handle that with a different fix: There is no icon for the default language (as there is no site config) when you edit a translated record.
  11. Josef Glatz rebased onto patch set 3 08/03/19, 13:59

  12. TYPO3com voted on patch set 3 V +1 08/03/19, 14:10 Completed build in 10m 30s on Sat, 3 Aug, 02:10 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35553

  13. Josef Glatz voted on patch set 3 V +1 CR +1 08/03/19, 20:36

  14. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/23/19, 14:24

  15. Josef Glatz uploaded patch set 4 08/24/19, 06:13

  16. TYPO3com commented on patch set 4 08/24/19, 06:25 Completed build in 11m 53s on Sat, 24 Aug, 06:25 AM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35811

  17. Daniel Goerz commented on patch set 4 CR -1 08/29/19, 09:56

    TranslationConfigurationProvider.php:75

    I dont get this. If you have 3 sites that all have german as a language and in the first it is called "German", in the second it is called "Deutsch" and in the third it is called "Global (DE)" than the translation button has the title "germandeutschglobal (de)". Seems questionable at least :) Why are we appending all titles here?
  18. Anja Leichsenring wrote 09/09/19, 13:37

    Removed reviewer Anja Leichsenring.
  19. Benni Mack commented on patch set 4 12/31/19, 13:23

    TranslationConfigurationProvider.php:75 Reply Unresolved

    I did a similar thing in AbstractItemProvider (for be_users.limitToLanguage), so somehow we need a good way to show that sys_language_uid=1 has three different meanings!
  20. Daniel Goerz uploaded patch set 5 01/12/20, 12:22

  21. TYPO3com voted on patch set 5 V -1 01/12/20, 12:37 Completed build in 12m 59s on Sun, 12 Jan, 12:37 PM Test Summary: 68726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39806

  22. TYPO3com voted on patch set 5 V +1 01/12/20, 12:58 Completed build in 47m 13s on Sun, 12 Jan, 12:58 PM Test Summary: 69203 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39806

  23. Daniel Goerz voted on patch set 5 V +1 CR +1 01/12/20, 12:58

  24. Susi Moog voted on patch set 5 V +2 CR +2 01/12/20, 14:54

  25. Susi Moog merged patch set 6 01/12/20, 14:54