61421[TASK] Remove inline markup for bitmap icons
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 79
-
Pascal Rinker uploaded patch set 1 08/02/19, 22:09
-
TYPO3com voted on patch set 1 V +1 08/02/19, 22:21 Completed build in 11m 41s on Fri, 2 Aug, 10:21 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35522
-
Guido Schmechel commented on patch set 1 08/03/19, 08:35
-
Pascal Rinker commented on patch set 1 08/05/19, 07:14
BitmapIconProvider.php:84Reply UnresolvedYou´re right. Do we need the inline markup for bitmaps at all? Never heard of it before in terms bitmap, just for SVG. -
Pascal Rinker uploaded patch set 2 08/05/19, 08:21
-
TYPO3com voted on patch set 2 V +1 08/05/19, 08:36 Completed build in 13m 28s on Mon, 5 Aug, 08:36 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35582
-
Frank Nägler commented on patch set 2 CR -2 10/25/19, 21:57
This will break the PageTree because the inline rendering is required for the bitmap icons within the SVGTree. https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href#image This is used in case a icon in the tree ist registered as a bitmap image. -
Benni Mack commented on patch set 2 04/30/20, 07:45
We've included a fix in TYPO3 v9.5.16 and TYPO3 v10.4.1 that should solve this issue, can you re-check if your change is still necessary? -
Benjamin Franzke abandoned the change 04/30/20, 08:02
Fixed by https://review.typo3.org/c/Packages/TYPO3.CMS/+/64325 tested with the reproduction steps in https://forge.typo3.org/issues/88402 which do work now.
BitmapIconProvider.php:84