Review main Merged

61422[BUGFIX] Deactivate link element's explanation toggle after change

Michael Straschek CR +2 V +2 Easy +19 −4 updated 11/09/19, 13:51

Commit message

Dynamically fetching/applying additional data for the link explanation
seems to be overdone, so we simply deactivate the toggle button and
remove the icon after selection/modification of the link target.
After persisting the record, the updated link explanation
will be visible.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • Alexander Stehlik +1
  • Verified V +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • Alexander Stehlik +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2133

Show 58 earlier messages
  1. Michael Straschek uploaded patch set 1 08/02/19, 22:17

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 08/02/19, 22:25

  3. TYPO3com voted on patch set 1 V -1 08/02/19, 22:29 Completed build in 11m 52s on Fri, 2 Aug, 10:29 PM Test Summary: 21 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35524

  4. TYPO3com voted on patch set 1 V +1 08/02/19, 22:32 Completed build in 27m 01s on Fri, 2 Aug, 10:32 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35524

  5. Oli Bartsch commented on patch set 1 CR -1 08/09/19, 12:31

    InputLinkElement.ts:36

    Should we not simply use the already existing event listener (line 62)?

    InputLinkElement.ts:72

    This is just a visual solution. Furthermore it also has some edge cases. For example if one changes the link to a page with a different doktype, the icon in front of the URL doesn't change. This also applies to a change of the linktype (internal link -> external link). This may will cause confusion besides the disabled toggle button.
  6. Oli Bartsch uploaded patch set 2 09/22/19, 17:19

  7. TYPO3com voted on patch set 2 V -1 09/22/19, 17:28 Completed build in 09m 21s on Sun, 22 Sep, 05:28 PM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36627

  8. Oli Bartsch commented on patch set 2 09/22/19, 17:30

    InputLinkElement.ts:36 Reply Unresolved

    I removed this duplicated eventListener and moved the method call into the already existing one.

    InputLinkElement.ts:72 Reply

    As the commit message states it out, fetching/applying the explanation dynamically after the change is maybe a litte bit overdone. So I'm fine with this solution for now. We have the same behaviour - update of icon only after persisting - also at other places e.g. type=group.
  1. TYPO3com voted on patch set 2 V +1 09/22/19, 18:05 Completed build in 56m 01s on Sun, 22 Sep, 06:05 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36627

  2. Oli Bartsch uploaded patch set 3 09/23/19, 06:48

  3. Oli Bartsch uploaded patch set 4 09/23/19, 06:49

  4. TYPO3com voted on patch set 3 V -1 09/23/19, 06:58 Completed build in 10m 28s on Mon, 23 Sep, 06:58 AM Test Summary: 47500 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36632

  5. TYPO3com voted on patch set 4 V +1 09/23/19, 06:59 Completed build in 10m 06s on Mon, 23 Sep, 06:59 AM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36633

  6. Steffen Frese uploaded patch set 5 10/10/19, 12:49

  7. Steffen Frese commented on patch set 5 10/10/19, 12:52

    InputLinkElement.ts:72 Reply

    there shouldn't be any confusion about the icon now.
  8. Steffen Frese uploaded patch set 6 10/10/19, 12:54

  9. TYPO3com voted on patch set 5 V -1 10/10/19, 13:01 Completed build in 12m 09s on Thu, 10 Oct, 01:01 PM Test Summary: 1 of 48078 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37208

  10. TYPO3com voted on patch set 6 V -1 10/10/19, 13:06 Completed build in 11m 41s on Thu, 10 Oct, 01:06 PM Test Summary: 1 of 48078 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37209

  11. TYPO3com voted on patch set 6 V +1 10/10/19, 13:28 Completed build in 11m 44s on Thu, 10 Oct, 01:28 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37211

  12. Oli Bartsch uploaded patch set 7 10/25/19, 18:52

  13. TYPO3com voted on patch set 7 V +1 10/25/19, 19:04 Completed build in 11m 38s on Fri, 25 Oct, 07:04 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37733

  14. Oli Bartsch voted on patch set 7 V +1 CR +1 10/25/19, 20:24

  15. Alexander Stehlik voted on patch set 7 V +1 CR +1 10/27/19, 11:08

  16. Susi Moog commented on patch set 7 10/28/19, 19:16

    Isn't this also a problem on 9.5?
  17. Oli Bartsch updated the commit message in patch set 8 10/28/19, 19:22

  18. Oli Bartsch commented on patch set 8 V +1 CR +1 10/28/19, 19:23

    > Patch Set 7: > > Isn't this also a problem on 9.5? Yes, it also affects 9.5. I updated the commit message accordingly.
  19. Alexander Stehlik voted on patch set 8 V +1 CR +1 10/28/19, 19:26

  20. TYPO3com voted on patch set 8 V -1 10/28/19, 19:42 Completed build in 18m 24s on Mon, 28 Oct, 07:42 PM Test Summary: 1 of 48430 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37828

  21. TYPO3com voted on patch set 8 V +1 10/28/19, 20:17 Completed build in 10m 16s on Mon, 28 Oct, 08:17 PM Test Summary: 48071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37831

  22. Susi Moog voted on patch set 8 CR +1 11/09/19, 13:30

  23. Susi Moog voted on patch set 8 V +2 CR +2 11/09/19, 13:51

  24. Susi Moog merged patch set 9 11/09/19, 13:51

  25. Susi Moog commented on patch set 9 11/09/19, 13:51

    @Andy: Please backport me.