61424[FEATURE] Render all fields in ElementInformationController
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Froemken +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Froemken +1
- TYPO3com +1 CI
Issues 1
Files 57
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php1+51 −30
- typo3/sysext/backend/Resources/Private/Templates/ContentElement/ElementInformation.html2+51 −33
- typo3/sysext/core/Classes/Category/CategoryRegistry.php+0 −9
- typo3/sysext/core/Configuration/TCA/be_groups.php+0 −3
- typo3/sysext/core/Configuration/TCA/be_users.php+0 −3
- typo3/sysext/core/Configuration/TCA/pages.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_category.php+0 −3
- typo3/sysext/core/Configuration/TCA/sys_collection.php+0 −3
- typo3/sysext/core/Configuration/TCA/sys_file.php+0 −3
- typo3/sysext/core/Configuration/TCA/sys_filemounts.php+0 −3
- typo3/sysext/core/Configuration/TCA/sys_file_collection.php+0 −3
- typo3/sysext/core/Configuration/TCA/sys_file_metadata.php+0 −3
- typo3/sysext/core/Configuration/TCA/sys_file_reference.php+0 −3
- typo3/sysext/core/Configuration/TCA/sys_file_storage.php+0 −3
- typo3/sysext/core/Configuration/TCA/sys_language.php+0 −3
- typo3/sysext/core/Configuration/TCA/sys_news.php+0 −3
- typo3/sysext/core/Documentation/Changelog/master/Feature-88901-RenderAllFieldsInElementInformationController.rst2new+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_hotel.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_offer.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_price.php+0 −3
Show 37 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_hotel.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_offer.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_price.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel_offer_rel.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_offer.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_price.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel_offer_rel.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_offer.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_hotel.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_offer.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_price.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel_rel.php+0 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/Configuration/TCA/tx_testdatahandler_element.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_blog.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_comment.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_dateexample.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_info.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_person.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_post.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_tag.php+0 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/class_overriding/a/Configuration/TCA/tx_a_domain_model_a.php+0 −3
- typo3/sysext/extensionmanager/Configuration/TCA/tx_extensionmanager_domain_model_extension.php+0 −3
- typo3/sysext/extensionmanager/Configuration/TCA/tx_extensionmanager_domain_model_repository.php+0 −3
- typo3/sysext/frontend/Configuration/TCA/backend_layout.php+0 −3
- typo3/sysext/frontend/Configuration/TCA/fe_groups.php+0 −3
- typo3/sysext/frontend/Configuration/TCA/fe_users.php+0 −3
- typo3/sysext/frontend/Configuration/TCA/pages_language_overlay.php+0 −3
- typo3/sysext/frontend/Configuration/TCA/sys_template.php+0 −3
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+0 −1
- typo3/sysext/indexed_search/Configuration/TCA/index_config.php+0 −3
- typo3/sysext/redirects/Configuration/TCA/sys_redirect.php+0 −3
- typo3/sysext/scheduler/Configuration/TCA/tx_scheduler_task_group.php+0 −3
- typo3/sysext/sys_note/Configuration/TCA/sys_note.php+0 −3
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+0 −6
Review log 2131
Show 46 earlier messages
-
Georg Ringer uploaded patch set 1 08/02/19, 23:00
-
TYPO3com voted on patch set 1 V +1 08/02/19, 23:11 Completed build in 10m 13s on Fri, 2 Aug, 11:11 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35526
-
Björn Jacob commented on patch set 1 08/03/19, 05:32
Feature-88901-RenderAllFieldsInElementInformationController.rst:18UnresolvedSame here. See proposal for comit message. -
Georg Ringer uploaded patch set 2 08/03/19, 07:50
-
Georg Ringer commented on patch set 2 08/03/19, 07:51
This change is ready for review. -
TYPO3com voted on patch set 2 V +1 08/03/19, 08:01 Completed build in 10m 54s on Sat, 3 Aug, 08:01 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35527
-
Georg Ringer uploaded patch set 3 08/03/19, 09:20
-
TYPO3com voted on patch set 3 V -1 08/03/19, 09:37 Completed build in 15m 51s on Sat, 3 Aug, 09:37 AM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35538
-
TYPO3com voted on patch set 3 V +1 08/03/19, 10:08 Completed build in 1h 03m 02s on Sat, 3 Aug, 10:08 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35538
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 09/25/19, 12:04
-
Björn Jacob voted on patch set 3 CR +1 09/25/19, 12:12
-
Daniel Goerz commented on patch set 3 09/25/19, 13:54
Feature-88901-RenderAllFieldsInElementInformationController.rst:18UnresolvedShould we add a TCAMigration for this? -
Georg Ringer commented on patch set 3 10/02/19, 03:41
@daniel: wanna add one? sure -
Georg Ringer uploaded patch set 4 10/31/19, 06:42
-
TYPO3com voted on patch set 4 V -1 10/31/19, 06:55 Completed build in 13m 07s on Thu, 31 Oct, 06:55 AM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37881
-
TYPO3com voted on patch set 4 V +1 10/31/19, 07:27 Completed build in 57m 53s on Thu, 31 Oct, 07:27 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37881
-
Georg Ringer uploaded patch set 5 02/14/20, 20:21
-
TYPO3com voted on patch set 5 V +1 02/14/20, 21:25 Completed build in 57m 11s on Fri, 14 Feb, 09:25 PM Test Summary: 71253 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-88
-
Stefan Froemken commented on patch set 5 V +1 CR +1 02/14/20, 23:17
Nice workElementInformationController.php:431UnresolvedRemove backslashElementInformation.html:19Unresolvedremove one empty line -
Stefan Froemken commented on patch set 5 CR -1 02/15/20, 08:18
Works, but I found two little suggestions in Code. -
Georg Ringer uploaded patch set 6 02/15/20, 08:25
-
TYPO3com voted on patch set 6 V -1 02/15/20, 08:47 Completed build in 17m 21s on Sat, 15 Feb, 08:47 AM Test Summary: 1 of 71451 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-99
-
TYPO3com voted on patch set 6 V +1 02/15/20, 09:19 Completed build in 1h 06m 44s on Sat, 15 Feb, 09:19 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-99
-
Stefan Froemken commented on patch set 6 V +1 CR +1 02/15/20, 09:28
Just tested, the fieldlist will be reduced for editors accordingly to their right. Perfect. -
Daniel Goerz commented on patch set 6 02/15/20, 13:35
ElementInformation.html:28UnresolvedThis looks odd in the info for (admin) backend users. Tested in Firefox, MacOS -
Georg Ringer uploaded patch set 7 02/15/20, 13:37
-
TYPO3com voted on patch set 7 V +1 02/15/20, 13:58 Completed build in 16m 16s on Sat, 15 Feb, 01:58 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-118
-
Benni Mack commented on patch set 7 CR +1 02/16/20, 23:11
I think this is OK for now. -
Stefan Froemken commented on patch set 7 V +1 CR +1 02/17/20, 10:58
Looks good to me. Happy merging ;-) -
Benni Mack voted on patch set 7 V +2 CR +2 02/17/20, 12:04
-
Benni Mack merged patch set 8 02/17/20, 12:04
Unresolved