Review main Merged

61424[FEATURE] Render all fields in ElementInformationController

Georg Ringer CR +2 V +2 Hard +122 −228 updated 02/17/20, 12:04

Commit message

The element information modal now shows all fields of the
current record and the selected type.

The TCA configuration `showRecordFieldList` inside the section `interface` is not evaluated anymore and all occurences have been removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Froemken +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Froemken +1
    • TYPO3com +1 CI

Issues 1

Files 57

Show 37 more files

Review log 2131

Show 46 earlier messages
  1. Georg Ringer uploaded patch set 1 08/02/19, 23:00

  2. TYPO3com voted on patch set 1 V +1 08/02/19, 23:11 Completed build in 10m 13s on Fri, 2 Aug, 11:11 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35526

  3. Björn Jacob commented on patch set 1 08/03/19, 05:32

    Unresolved

    Some minor problems with grammer. Here is my proposal: "The TCA configuration `showRecordFieldList` inside the section `interface` is not evaluated anymore and all occurences have been removed."

    Feature-88901-RenderAllFieldsInElementInformationController.rst:18 Unresolved

    Same here. See proposal for comit message.
  4. Georg Ringer uploaded patch set 2 08/03/19, 07:50

  5. Georg Ringer commented on patch set 2 08/03/19, 07:51

    This change is ready for review.
  6. TYPO3com voted on patch set 2 V +1 08/03/19, 08:01 Completed build in 10m 54s on Sat, 3 Aug, 08:01 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35527

  1. Georg Ringer uploaded patch set 3 08/03/19, 09:20

  2. TYPO3com voted on patch set 3 V -1 08/03/19, 09:37 Completed build in 15m 51s on Sat, 3 Aug, 09:37 AM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35538

  3. TYPO3com voted on patch set 3 V +1 08/03/19, 10:08 Completed build in 1h 03m 02s on Sat, 3 Aug, 10:08 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35538

  4. Anja Leichsenring voted on patch set 3 V +1 CR +1 09/25/19, 12:04

  5. Björn Jacob voted on patch set 3 CR +1 09/25/19, 12:12

  6. Daniel Goerz commented on patch set 3 09/25/19, 13:54

    Feature-88901-RenderAllFieldsInElementInformationController.rst:18 Unresolved

    Should we add a TCAMigration for this?
  7. Georg Ringer commented on patch set 3 10/02/19, 03:41

    @daniel: wanna add one? sure
  8. Georg Ringer uploaded patch set 4 10/31/19, 06:42

  9. TYPO3com voted on patch set 4 V -1 10/31/19, 06:55 Completed build in 13m 07s on Thu, 31 Oct, 06:55 AM Test Summary: 1 of 48438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37881

  10. TYPO3com voted on patch set 4 V +1 10/31/19, 07:27 Completed build in 57m 53s on Thu, 31 Oct, 07:27 AM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37881

  11. Georg Ringer uploaded patch set 5 02/14/20, 20:21

  12. TYPO3com voted on patch set 5 V +1 02/14/20, 21:25 Completed build in 57m 11s on Fri, 14 Feb, 09:25 PM Test Summary: 71253 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-88

  13. Stefan Froemken commented on patch set 5 V +1 CR +1 02/14/20, 23:17

    Nice work

    ElementInformationController.php:431 Unresolved

    Remove backslash

    ElementInformation.html:19 Unresolved

    remove one empty line
  14. Stefan Froemken commented on patch set 5 CR -1 02/15/20, 08:18

    Works, but I found two little suggestions in Code.
  15. Georg Ringer uploaded patch set 6 02/15/20, 08:25

  16. TYPO3com voted on patch set 6 V -1 02/15/20, 08:47 Completed build in 17m 21s on Sat, 15 Feb, 08:47 AM Test Summary: 1 of 71451 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-99

  17. TYPO3com voted on patch set 6 V +1 02/15/20, 09:19 Completed build in 1h 06m 44s on Sat, 15 Feb, 09:19 AM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-99

  18. Stefan Froemken commented on patch set 6 V +1 CR +1 02/15/20, 09:28

    Just tested, the fieldlist will be reduced for editors accordingly to their right. Perfect.
  19. Daniel Goerz commented on patch set 6 02/15/20, 13:35

    ElementInformation.html:28 Unresolved

    This looks odd in the info for (admin) backend users. Tested in Firefox, MacOS
  20. Georg Ringer uploaded patch set 7 02/15/20, 13:37

  21. TYPO3com voted on patch set 7 V +1 02/15/20, 13:58 Completed build in 16m 16s on Sat, 15 Feb, 01:58 PM Test Summary: 71295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-118

  22. Benni Mack commented on patch set 7 CR +1 02/16/20, 23:11

    I think this is OK for now.
  23. Stefan Froemken commented on patch set 7 V +1 CR +1 02/17/20, 10:58

    Looks good to me. Happy merging ;-)
  24. Benni Mack voted on patch set 7 V +2 CR +2 02/17/20, 12:04

  25. Benni Mack merged patch set 8 02/17/20, 12:04