Review main Merged

61425[BUGFIX] Support multiple order by fields in PageRepository

Georg Großberger CR +2 V +2 Easy +1 −1 updated 08/06/19, 12:28

Commit message

The method PageRepository::getSubpagesForPages allows an arbitrary
number of orderBy fields, though the way it is passed to the
query builder, only the last field is used.

This patch simply changes the DBAL call to ->addOrderBy to ensure
all set order by fields are used, in the order they are defined.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Georg Großberger uploaded patch set 1 08/03/19, 08:14

  2. Georg Ringer voted on patch set 1 V +1 CR +1 08/03/19, 08:22

  3. TYPO3com voted on patch set 1 V +1 08/03/19, 08:23 Completed build in 09m 31s on Sat, 3 Aug, 08:23 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35530

  4. Frank Nägler voted on patch set 1 V +2 CR +2 08/06/19, 12:22

  5. Frank Nägler merged patch set 2 08/06/19, 12:28