Review main Merged

61428[FEATURE] Always enable filter in SelectMultipleSideBySide fields

Georg Ringer CR +2 V +2 Normal +143 −42 updated 09/04/19, 13:01

Commit message

The filter functionality of fields `type = select` with
renderType = selectMultipleSideBySide is always enabled now.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Markus Klein +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Susi Moog +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 2129

Show 34 earlier messages
  1. Georg Ringer uploaded patch set 1 08/03/19, 13:10

  2. Georg Ringer commented on patch set 1 08/03/19, 13:10

    This change is ready for review.
  3. Georg Ringer rebased onto patch set 2 08/03/19, 13:18

  4. TYPO3com voted on patch set 1 V +1 08/03/19, 13:29 Completed build in 18m 38s on Sat, 3 Aug, 01:29 PM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35546

  1. TYPO3com voted on patch set 2 V +1 08/03/19, 13:41 Completed build in 14m 47s on Sat, 3 Aug, 01:41 PM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35550

  2. Susi Moog voted on patch set 2 CR +1 08/08/19, 14:19

  3. Anja Leichsenring uploaded patch set 3 08/24/19, 15:36

  4. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/24/19, 15:40

  5. TYPO3com voted on patch set 3 V +1 08/24/19, 15:46 Completed build in 10m 03s on Sat, 24 Aug, 03:46 PM Test Summary: 47231 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35824

  6. Benni Mack commented on patch set 3 08/27/19, 13:52

    SelectMultipleSideBySideElement.php:172 Unresolved

    now $filterTextfield is never empty. So this check is superfluous, also similar: two lines below.

    TcaMigration.php:193 Unresolved

    "as it is enabled by default now"
  7. Tymoteusz Motylewski commented on patch set 3 08/27/19, 14:56

    If i read correctly, it's not only enabled by default, but always enabled/visible (there is no way to disable it). Let's change the description to avoid confusion.
  8. Daniel Goerz uploaded patch set 4 08/29/19, 08:35

  9. Daniel Goerz commented on patch set 4 08/29/19, 08:36

    I changed the wording to make it clear that the filter is always enabled now. Question remains if we therefore want an option to disable the filter?
  10. TYPO3com voted on patch set 4 V -1 08/29/19, 08:44 Completed build in 09m 41s on Thu, 29 Aug, 08:44 AM Test Summary: 2 of 47603 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35911

  11. TYPO3com voted on patch set 4 V +1 08/29/19, 09:26 Completed build in 10m 06s on Thu, 29 Aug, 09:26 AM Test Summary: 47244 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35913

  12. Georg Ringer commented on patch set 4 08/29/19, 16:47

    @daniel: the thing is we want better defaults AND less options. there is no reason to hide that
  13. Georg Ringer voted on patch set 4 V +1 CR +1 08/29/19, 16:47

  14. Richard Haeser commented on patch set 4 CR +1 08/29/19, 20:16

    IMHO I think this one might need some extra attention with an important or maybe even deprecation rst file. I totally agree we should make better defaults and less options, so I'm fine with the change. Only thing is that people had the option to remove it, they will see it always now, so we might give it some more attention with an extra rst file why this option is removed.
  15. Richard Haeser commented on patch set 4 V -1 CR -1 08/29/19, 20:36

    It is now only showing the filter field when there are filterDropDownOptions. I guess that is not the idea?

    SelectMultipleSideBySideElement.php:172

    Is it correct that you now only show the search field when there are filterDropDown options?
  16. Daniel Goerz commented on patch set 4 08/30/19, 06:59

    SelectMultipleSideBySideElement.php:172 Reply Unresolved

    You are correct. Sorry for that, will clean that up
  17. Daniel Goerz uploaded patch set 5 08/30/19, 07:01

  18. TYPO3com voted on patch set 5 V +1 08/30/19, 07:13 Completed build in 11m 33s on Fri, 30 Aug, 07:13 AM Test Summary: 47244 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35945

  19. Markus Klein uploaded patch set 6 09/02/19, 20:14

  20. Markus Klein voted on patch set 6 CR +1 09/02/19, 20:14

  21. TYPO3com voted on patch set 6 V -1 09/02/19, 20:26 Completed build in 11m 30s on Mon, 2 Sep, 08:26 PM Test Summary: 47010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36002

  22. TYPO3com voted on patch set 6 V +1 09/02/19, 21:42 Completed build in 1h 39m 37s on Mon, 2 Sep, 09:42 PM Test Summary: 47256 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36002

  23. Richard Haeser voted on patch set 6 V +1 CR +1 09/03/19, 21:24

  24. Susi Moog voted on patch set 6 V +2 CR +2 09/04/19, 13:01

  25. Susi Moog merged patch set 7 09/04/19, 13:01