Review main Merged

61430[BUGFIX] Pass FrontendUserAuthentication to redirect handling

Andreas Kienast CR +2 V +2 Easy +18 −13 updated 08/04/19, 08:25

Commit message

`$GLOBALS['TSFE']->fe_user` is not available in the RedirectService. This
patch now explicitly passes the `frontend.user` attribute of the current
request to the RedirectService.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 69

  1. Andreas Kienast uploaded patch set 1 08/03/19, 13:12

  2. TYPO3com voted on patch set 1 V -1 08/03/19, 13:38 Completed build in 22m 09s on Sat, 3 Aug, 01:38 PM Test Summary: 29 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35549

  3. TYPO3com commented on patch set 1 08/03/19, 13:43 Completed build in 49m 28s on Sat, 3 Aug, 01:43 PM Test Summary: 24 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35549

  4. Andreas Kienast uploaded patch set 2 08/03/19, 14:28

  5. TYPO3com voted on patch set 2 V +1 08/03/19, 14:38 Completed build in 09m 37s on Sat, 3 Aug, 02:38 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35555

  6. Susi Moog voted on patch set 2 CR +1 08/03/19, 16:27

  7. Susi Moog voted on patch set 2 V +1 08/03/19, 16:44

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/04/19, 08:23

  9. Anja Leichsenring merged patch set 3 08/04/19, 08:25