61432[BUGFIX] OtherLanguageContent: show fallback language icon
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Oli Bartsch +1
-
Verified V +2 Done
- Susi Moog +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1519
-
Josef Glatz uploaded patch set 1 08/03/19, 13:59
-
TYPO3com voted on patch set 1 V +1 08/03/19, 14:11 Completed build in 11m 10s on Sat, 3 Aug, 02:11 PM Test Summary: 47171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35554
-
Josef Glatz updated the commit message in patch set 2 08/05/19, 04:16
-
TYPO3com voted on patch set 2 V +1 08/05/19, 04:29 Completed build in 12m 23s on Mon, 5 Aug, 04:29 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35576
-
Oli Bartsch commented on patch set 2 08/20/19, 08:05
-
Josef Glatz uploaded patch set 3 08/24/19, 06:13
-
Josef Glatz commented on patch set 3 08/24/19, 06:14
OtherLanguageContent.php:77ReplyDone -
TYPO3com voted on patch set 3 V +1 08/24/19, 06:30 Completed build in 16m 43s on Sat, 24 Aug, 06:30 AM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35812
-
Oli Bartsch commented on patch set 3 08/24/19, 06:50
OtherLanguageContent.php:73What do you think about doing this in one line and remove the single use variable declaration? But I'll be fine with both solutions. -
Richard Haeser commented on patch set 3 CR +1 09/07/19, 07:08
OtherLanguageContent.php:73ReplyReadability wise I prefer this way, but I'm fine with both solutions as well. -
Oli Bartsch commented on patch set 3 09/08/19, 22:34
OtherLanguageContent.php:73ReplyMy thought was, that on each line the `$html` array gets extended. The declaration of `$iconIdentifier` breaks this procedure and is also single use declaration. -
Steffen Frese voted on patch set 3 CR +1 10/10/19, 06:47
-
Georg Ringer commented on patch set 3 10/10/19, 06:53
OtherLanguageContent.php:73Replyjust move the $iconIdentifier to 1st line in the if condition and it will look fine -
Oli Bartsch commented on patch set 3 10/10/19, 11:38
OtherLanguageContent.php:73Reply UnresolvedAgreed, this would be also a good solution I think. -
Oli Bartsch uploaded patch set 4 11/02/19, 20:39
-
Oli Bartsch voted on patch set 4 V +1 CR +1 11/02/19, 20:39
-
TYPO3com voted on patch set 4 V +1 11/02/19, 20:49 Completed build in 10m 30s on Sat, 2 Nov, 08:49 PM Test Summary: 48079 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37931
-
Susi Moog voted on patch set 4 V +2 CR +2 11/05/19, 19:07
-
Susi Moog merged patch set 5 11/05/19, 19:07
OtherLanguageContent.php:77