Review main Merged

61433[BUGFIX] Fix tests with phpunit 8.3.2

Anja Leichsenring CR +2 V +2 Easy +26 −11 updated 08/04/19, 04:40

Commit message

The new minor version of phpunit comes with a (probably) bug in their
mock API that causes errors in reflection and ClassSchema construction.
Also, partial mock with a function that does not exist, will now throw
a warning.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Anja Leichsenring uploaded patch set 1 08/03/19, 16:15

  2. Susi Moog voted on patch set 1 CR +1 08/03/19, 16:24

  3. TYPO3com voted on patch set 1 V +1 08/03/19, 16:27 Completed build in 11m 41s on Sat, 3 Aug, 04:27 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35556

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 08/03/19, 16:52

  5. Georg Ringer voted on patch set 1 V +2 CR +2 08/04/19, 04:40

  6. Georg Ringer merged patch set 2 08/04/19, 04:40