Review main Merged

61434[TASK] Sort php-cs-fixer rules by name

Andreas Kienast CR +2 V +2 Normal +27 −27 updated 08/04/19, 08:51

Commit message

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Susi Moog +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1115

  1. Andreas Kienast uploaded patch set 1 08/03/19, 16:41

  2. Guido Schmechel commented on patch set 1 08/03/19, 16:44

    .php_cs:92

    Two p entries following..
  3. Andreas Kienast commented on patch set 1 08/03/19, 16:48

    .php_cs:92 Reply Unresolved

    damn it
  4. Andreas Kienast uploaded patch set 2 08/03/19, 16:49

  5. Oliver Klee voted on patch set 2 CR +1 08/03/19, 16:52

  6. TYPO3com voted on patch set 1 V +1 08/03/19, 16:54 Completed build in 13m 43s on Sat, 3 Aug, 04:54 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35557

  7. TYPO3com voted on patch set 2 V -1 08/03/19, 16:59 Completed build in 10m 29s on Sat, 3 Aug, 04:59 PM Test Summary: 5 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35558

  8. TYPO3com voted on patch set 2 V +1 08/03/19, 17:02 Completed build in 24m 05s on Sat, 3 Aug, 05:02 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35558

  9. Josef Glatz commented on patch set 2 CR -1 08/03/19, 20:52

    .php_cs:57

    Any reason why these lines aren't sorted?

    .php_cs:66

    please mention the newly added rules in the commit message

    .php_cs:69 Unresolved

    please mention the newly added rules in the commit message
  10. Andreas Kienast commented on patch set 2 08/03/19, 21:05

    .php_cs:57 Reply Unresolved

    I forgot them.

    .php_cs:66 Reply Unresolved

    They were some tests I forgot to remove
  11. Andreas Kienast uploaded patch set 3 08/04/19, 07:18

  12. TYPO3com voted on patch set 3 V +1 08/04/19, 07:28 Completed build in 09m 52s on Sun, 4 Aug, 07:28 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35562

  13. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/04/19, 08:16

  14. Susi Moog voted on patch set 3 V +2 CR +2 08/04/19, 08:51

  15. Susi Moog merged patch set 4 08/04/19, 08:51