Review main Merged

61435[TASK] Update nikic/php-parser to 4.2

Andreas Kienast CR +2 V +2 Easy +10 −10 updated 08/05/19, 06:41

Commit message

This patch updates nikic/php-parser to version 4.2.2, which brings
better support for PHP 7.3 and adds initial support for PHP 7.4.

Changelog: https://raw.githubusercontent.com/nikic/PHP-Parser/v4.2.2/CHANGELOG.md

Composer command:

  composer require nikic/php-parser:^4.2

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 811

  1. Andreas Kienast uploaded patch set 1 08/04/19, 08:15

  2. TYPO3com voted on patch set 1 V -1 08/04/19, 08:25 Completed build in 10m 05s on Sun, 4 Aug, 08:25 AM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35563

  3. Andreas Kienast uploaded patch set 2 08/04/19, 08:46

  4. TYPO3com voted on patch set 2 V -1 08/04/19, 08:58 Completed build in 12m 17s on Sun, 4 Aug, 08:58 AM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35565

  5. TYPO3com voted on patch set 2 V +1 08/04/19, 09:10 Completed build in 36m 57s on Sun, 4 Aug, 09:10 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35565

  6. Susi Moog voted on patch set 2 CR +1 08/04/19, 09:19

  7. Susi Moog voted on patch set 2 V +1 08/04/19, 09:38

  8. Oliver Klee voted on patch set 2 CR +1 08/04/19, 11:43

  9. Georg Ringer voted on patch set 2 V +1 CR +1 08/04/19, 13:29

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 08/05/19, 06:41

  11. Andreas Kienast merged patch set 3 08/05/19, 06:41