Review 9.5 Merged

61439[TASK] Update nikic/php-parser to 4.2

Andreas Kienast CR +2 V +2 Easy +10 −10 updated 08/05/19, 07:11

Commit message

This patch updates nikic/php-parser to version 4.2.2, which brings
better support for PHP 7.3 and adds initial support for PHP 7.4.

Changelog: https://raw.githubusercontent.com/nikic/PHP-Parser/v4.2.2/CHANGELOG.md

Composer command:

  composer require nikic/php-parser:^4.2

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 35

  1. Andreas Kienast uploaded patch set 1 08/05/19, 06:43

  2. TYPO3com voted on patch set 1 V -1 08/05/19, 06:56 Completed build in 13m 22s on Mon, 5 Aug, 06:56 AM Test Summary: 9 of 50997 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-959

  3. TYPO3com voted on patch set 1 V +1 08/05/19, 07:06 Completed build in 36m 08s on Mon, 5 Aug, 07:06 AM Test Summary: 50529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-959

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 08/05/19, 07:11

  5. Andreas Kienast merged patch set 2 08/05/19, 07:11