Review main Merged

61451[BUGFIX] Disable autocompletion in installation options

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 08/08/19, 07:46

Commit message

Since Chrome is really picky about having autocomplete disabled, this
patch sets the autocomplete configuration for password fields to
`new-password` used in "Configure Installation-Wide Options". This is a
proposed workaround mentioned at MDN:

  https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#Preventing_autofilling_with_autocompletenew-password

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Josef Glatz +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 08/07/19, 09:28

  2. TYPO3com voted on patch set 1 V +1 08/07/19, 09:38 Completed build in 09m 31s on Wed, 7 Aug, 09:38 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35621

  3. Josef Glatz voted on patch set 1 V +1 CR +1 08/07/19, 15:12

  4. Oliver Klee voted on patch set 1 CR +1 08/07/19, 16:01

  5. Frank Nägler voted on patch set 1 V +2 CR +2 08/08/19, 07:45

  6. Frank Nägler merged patch set 2 08/08/19, 07:46