Review TYPO3_8-7 Merged

61455[BUGFIX] Make redis pconnect calls unique

Frank Nägler CR +2 V +2 Easy +4 −2 updated 08/07/19, 12:34

Commit message

By using the persistent_id parameter of the redis->pconnect
method, we ensure that the connection is not shared between
multiple Redis*Backends connecting to the same Redis server.

Omitting the persistent_id causes the same connection to be reused
whenever another Redis*Backend is created, whereby the last
connection selects the database to use for the connection, effectively
causing all Redis*Backends to write to the same database.

The RedisSessionBackend uses the pconnect method by default and
therefore requires this fix in order to distinguish FE and BE
backends correctly, if both are stored within a Redis database.

The pconnect is optional for the cache RedisBackend, but we still
use the database number now for the persistent_id parameter.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Frank Nägler commented on patch set 1 08/07/19, 10:30

    Cherry Picked from branch 9.5.
  2. TYPO3com voted on patch set 1 V +1 08/07/19, 10:55 Completed build in 25m 19s on Wed, 7 Aug, 10:55 AM Test Summary: 80366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3587

  3. Frank Nägler voted on patch set 1 V +2 CR +2 08/07/19, 11:31

  4. Susi Moog voted on patch set 1 V +1 CR +1 08/07/19, 12:28

  5. Frank Nägler merged patch set 2 08/07/19, 12:34