Review 9.5 Merged

61459[BUGFIX] Disable autocompletion in installation options

Frank Nägler CR +2 V +2 Easy +1 −1 updated 08/08/19, 08:32

Commit message

Since Chrome is really picky about having autocomplete disabled, this
patch sets the autocomplete configuration for password fields to
`new-password` used in "Configure Installation-Wide Options". This is a
proposed workaround mentioned at MDN:

  https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#Preventing_autofilling_with_autocompletenew-password

Review

  • Code review CR +2 Done
    • Frank Nägler +2
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 57

  1. Frank Nägler commented on patch set 1 08/08/19, 07:46

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/install/Resources/Private/Partials/Settings/LocalConfiguration/SubSection.html
  2. Frank Nägler uploaded patch set 2 08/08/19, 07:49

  3. Frank Nägler commented on patch set 2 08/08/19, 07:49

    This change is ready for review.
  4. TYPO3com voted on patch set 1 V +1 08/08/19, 08:01 Completed build in 15m 21s on Thu, 8 Aug, 08:01 AM Test Summary: 50529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-989

  5. TYPO3com voted on patch set 2 V +1 08/08/19, 08:10 Completed build in 15m 27s on Thu, 8 Aug, 08:10 AM Test Summary: 50529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-990

  6. Frank Nägler voted on patch set 2 V +2 CR +2 08/08/19, 08:32

  7. Frank Nägler merged patch set 3 08/08/19, 08:32