Review 9.5 Merged

61463[BUGFIX] Ensure test environment is bootstrapped for cache backend tests

Frank Nägler CR +2 V +2 Easy +4 −4 updated 08/13/19, 11:22

Commit message

The cache backends tests need a bootstrapped test environment, since vital
parts are not booted at all, e.g. the Environment is undefined.

For this reason, the parent `setUp()` method is now called, albeit this
was not required previously.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 611

  1. Frank Nägler commented on patch set 1 08/09/19, 11:42

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Tests/Functional/Cache/Backend/RedisBackendTest.php
  2. TYPO3com voted on patch set 1 V -1 08/09/19, 11:42 Completed build in 11s on Fri, 9 Aug, 11:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-998

  3. Frank Nägler uploaded patch set 2 08/09/19, 11:43

  4. Frank Nägler commented on patch set 2 08/09/19, 11:44

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V -1 08/09/19, 11:56 Completed build in 12m 39s on Fri, 9 Aug, 11:56 AM Test Summary: 84 of 51001 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-999

  6. TYPO3com commented on patch set 2 08/09/19, 12:14 Completed build in 43m 18s on Fri, 9 Aug, 12:14 PM Test Summary: 84 of 51001 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-999

  7. TYPO3com commented on patch set 2 08/09/19, 13:21 Completed build in 2h 21m 16s on Fri, 9 Aug, 01:21 PM Test Summary: 84 of 51001 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-999

  8. Andreas Kienast rebased onto patch set 3 08/12/19, 18:03

  9. TYPO3com voted on patch set 3 V +1 08/12/19, 18:27 Completed build in 14m 51s on Mon, 12 Aug, 06:27 PM Test Summary: 50533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1003

  10. Frank Nägler voted on patch set 3 V +2 CR +2 08/13/19, 11:22

  11. Frank Nägler merged patch set 4 08/13/19, 11:22