Review 9.5 Merged

61464[BUGFIX] Increase memory cost of argon2i and force testing mariadb 10.3

Andreas Kienast CR +2 V +2 Easy +13 −13 updated 08/12/19, 18:02

Commit message

Due to security reasons, PHP's default memory_cost of argon2i has been
increased from 16384 to 65536:

  https://bugs.php.net/bug.php?id=78269

We shouldn't lower the factory default, thus this patch alignes the
hashing implementation.

Furthermore, mariadb 10.4 currently crashes with the functional
tests. The patch forces 10.3 for now to make bamboo green again.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 46

  1. Andreas Kienast commented on patch set 1 08/12/19, 17:26

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 08/12/19, 17:39 Completed build in 12m 41s on Mon, 12 Aug, 05:39 PM Test Summary: 4 of 51001 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1001

  3. Andreas Kienast uploaded patch set 2 08/12/19, 17:49

  4. Andreas Kienast voted on patch set 2 V +2 CR +2 08/12/19, 17:58

  5. TYPO3com voted on patch set 2 V +1 08/12/19, 18:02 Completed build in 12m 03s on Mon, 12 Aug, 06:02 PM Test Summary: 50533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1002

  6. Andreas Kienast merged patch set 3 08/12/19, 18:02