Review TYPO3_8-7 Merged

61467[BUGFIX] Process t3:// link resources correctly

Frank Nägler CR +2 V +2 Hard +313 −13 updated 08/15/19, 16:03

Commit message

* t3://email?email=oliver@typo3.org (be greedy about missing mailto:)
* t3://file?identifier=1:/logo.png (not implemented since no integer)

Besides that according test cases are added in order to ensure the
basic behavior of link handling in a TypoScript frontend rendering
scenario using t3:// link resources.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1117

  1. Frank Nägler commented on patch set 1 08/15/19, 11:58

    Cherry Picked from branch 9.5.
  2. Oliver Hader commented on patch set 1 08/15/19, 12:08

    TypoLinkTest.php:68 Unresolved

    Internal Requests most probably are not available in testing framework of v8
  3. TYPO3com voted on patch set 1 V -1 08/15/19, 12:12 Completed build in 14m 02s on Thu, 15 Aug, 12:12 PM Test Summary: 375 of 80590 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3595

  4. Frank Nägler commented on patch set 2 08/15/19, 12:20

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V -1 08/15/19, 12:34 Completed build in 11m 07s on Thu, 15 Aug, 12:34 PM Test Summary: 80042 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3596

  6. TYPO3com commented on patch set 2 08/15/19, 12:38 Completed build in 27m 01s on Thu, 15 Aug, 12:38 PM Test Summary: 80042 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3596

  7. TYPO3com commented on patch set 2 08/15/19, 12:40 Completed build in 44m 12s on Thu, 15 Aug, 12:40 PM Test Summary: 80042 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3596

  8. Andreas Kienast commented on patch set 2 CR -1 08/15/19, 13:45

    Class 'TYPO3\CMS\Frontend\Tests\Functional\SiteHandling\AbstractTestCase' not found in /srv/bamboo/xml-data/build-dir/CORE-GTC87-FPGPHP7009/typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkTest.php
  9. Oliver Hader uploaded patch set 3 08/15/19, 13:46

  10. TYPO3com voted on patch set 3 V -1 08/15/19, 13:56 Completed build in 10m 08s on Thu, 15 Aug, 01:56 PM Test Summary: 2 of 80948 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3597

  11. Oliver Hader uploaded patch set 4 08/15/19, 14:00

  12. TYPO3com voted on patch set 4 V +1 08/15/19, 14:11 Completed build in 10m 38s on Thu, 15 Aug, 02:11 PM Test Summary: 80400 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3598

  13. Frank Nägler voted on patch set 4 CR +1 08/15/19, 14:13

  14. Frank Nägler voted on patch set 4 V +1 08/15/19, 14:17

  15. Frank Nägler voted on patch set 4 V +2 CR +2 08/15/19, 14:18

  16. Frank Nägler merged patch set 5 08/15/19, 14:18

  17. Oliver Hader voted on patch set 5 CR +1 08/15/19, 16:03