Review main Merged

61472[BUGFIX] Instantiate Logger on cache backend creation

Anja Leichsenring CR +2 V +2 Easy +22 −0 updated 08/08/19, 11:53

Commit message

Cache backends are created via new, not using GU::makeInstance.
So it happened no cache has been initialized, causing errors upon
calls for the logger.
Putting cache creation into the cache backend constructor solves
the problem and makes sure the logger is always available.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 7

Review log 1216

  1. Anja Leichsenring uploaded patch set 1 08/07/19, 11:42

  2. TYPO3com voted on patch set 1 V -1 08/07/19, 11:57 Completed build in 12m 55s on Wed, 7 Aug, 11:57 AM Test Summary: 215 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35624

  3. Anja Leichsenring uploaded patch set 2 08/07/19, 12:14

  4. Anja Leichsenring uploaded patch set 3 08/07/19, 12:25

  5. TYPO3com voted on patch set 2 V -1 08/07/19, 12:25 Completed build in 10m 38s on Wed, 7 Aug, 12:25 PM Test Summary: 3 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35625

  6. Anja Leichsenring uploaded patch set 4 08/07/19, 12:30

  7. TYPO3com voted on patch set 3 V -1 08/07/19, 12:38 Completed build in 13m 15s on Wed, 7 Aug, 12:38 PM Test Summary: 3 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35626

  8. TYPO3com voted on patch set 4 V +1 08/07/19, 12:44 Completed build in 14m 00s on Wed, 7 Aug, 12:44 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35627

  9. Frank Nägler commented on patch set 4 08/08/19, 08:25

    Could we change the new operator with GU::makeInstance in CacheManager? I currently see no reason for the new operator.
  10. Frank Nägler commented on patch set 4 08/08/19, 08:26

    > Patch Set 4: > > Could we change the new operator with GU::makeInstance in CacheManager? > I currently see no reason for the new operator. ok, pre boostrap... I found the comment in the code...
  11. Frank Nägler voted on patch set 4 CR +1 08/08/19, 08:27

  12. Frank Nägler voted on patch set 4 V +1 08/08/19, 08:27

  13. Andreas Kienast voted on patch set 4 V +2 CR +2 08/08/19, 11:29

  14. Andreas Kienast merged patch set 5 08/08/19, 11:29

  15. Helmut Hummel commented on patch set 5 08/08/19, 11:49

    AbstractBackend.php:83

    using __CLASS__ here means, the logger will always use AbstractBackend as logging target. intentional?
  16. Frank Nägler commented on patch set 5 08/08/19, 11:53

    AbstractBackend.php:83 Reply Unresolved

    good catch Helmut, you are right. This should be changed.