61472[BUGFIX] Instantiate Logger on cache backend creation
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Frank Nägler +1
-
Verified V +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 2
Files 7
- typo3/sysext/core/Classes/Cache/Backend/AbstractBackend.php2+8 −0
- typo3/sysext/core/Tests/Functional/Cache/Backend/RedisBackendTest.php+4 −0
- typo3/sysext/core/Tests/Unit/Cache/Backend/AbstractBackendTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Cache/Backend/ApcuBackendTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Cache/Backend/TransientMemoryBackendTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Cache/Backend/Typo3DatabaseBackendTest.php+2 −0
Review log 1216
-
Anja Leichsenring uploaded patch set 1 08/07/19, 11:42
-
TYPO3com voted on patch set 1 V -1 08/07/19, 11:57 Completed build in 12m 55s on Wed, 7 Aug, 11:57 AM Test Summary: 215 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35624
-
Anja Leichsenring uploaded patch set 2 08/07/19, 12:14
-
Anja Leichsenring uploaded patch set 3 08/07/19, 12:25
-
TYPO3com voted on patch set 2 V -1 08/07/19, 12:25 Completed build in 10m 38s on Wed, 7 Aug, 12:25 PM Test Summary: 3 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35625
-
Anja Leichsenring uploaded patch set 4 08/07/19, 12:30
-
TYPO3com voted on patch set 3 V -1 08/07/19, 12:38 Completed build in 13m 15s on Wed, 7 Aug, 12:38 PM Test Summary: 3 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35626
-
TYPO3com voted on patch set 4 V +1 08/07/19, 12:44 Completed build in 14m 00s on Wed, 7 Aug, 12:44 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35627
-
Frank Nägler commented on patch set 4 08/08/19, 08:25
Could we change the new operator with GU::makeInstance in CacheManager? I currently see no reason for the new operator. -
Frank Nägler commented on patch set 4 08/08/19, 08:26
> Patch Set 4: > > Could we change the new operator with GU::makeInstance in CacheManager? > I currently see no reason for the new operator. ok, pre boostrap... I found the comment in the code... -
Frank Nägler voted on patch set 4 CR +1 08/08/19, 08:27
-
Frank Nägler voted on patch set 4 V +1 08/08/19, 08:27
-
Andreas Kienast voted on patch set 4 V +2 CR +2 08/08/19, 11:29
-
Andreas Kienast merged patch set 5 08/08/19, 11:29
-
Helmut Hummel commented on patch set 5 08/08/19, 11:49
AbstractBackend.php:83using __CLASS__ here means, the logger will always use AbstractBackend as logging target. intentional? -
Frank Nägler commented on patch set 5 08/08/19, 11:53
AbstractBackend.php:83Reply Unresolvedgood catch Helmut, you are right. This should be changed.