Review main Merged

61474[TASK] Respect default_sortby in TCA foreign table queries

Christoph Lehmann CR +2 V +2 Easy +7 −0 updated 01/15/20, 13:35

Commit message

Currently an ORDER BY clause is needed in foreign_table_where
to get a sorting. This makes it obsolete in favor of the default
tables sorting through default_sortby. This concerns TCA's
select and tree fields.

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Sascha Rademacher +1
    • Jörg Bösche +1
    • Felix P. +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Sascha Rademacher +1
    • Jörg Bösche +1
    • Felix P. +1
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1924

  1. Christoph Lehmann uploaded patch set 1 08/07/19, 22:33

  2. TYPO3com voted on patch set 1 V -1 08/07/19, 22:34 Completed build in 12s on Wed, 7 Aug, 10:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35635

  3. Mathias Brodala commented on patch set 1 CR -1 08/08/19, 07:09

    AbstractItemProvider.php:1006

    You cannot use this value as is since it can contain SQL fragments. Please use QueryHelper::parseOrderBy() before.
  4. Christoph Lehmann uploaded patch set 2 08/08/19, 10:59

  5. TYPO3com voted on patch set 2 V -1 08/08/19, 10:59 Completed build in 11s on Thu, 8 Aug, 10:59 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35647

  6. Christoph Lehmann uploaded patch set 3 08/08/19, 11:07

  7. Christoph Lehmann commented on patch set 3 08/08/19, 11:17

    AbstractItemProvider.php:1006 Reply

    Done
  8. TYPO3com voted on patch set 3 V +1 08/08/19, 11:17 Completed build in 10m 02s on Thu, 8 Aug, 11:17 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35648

  9. Sascha Rademacher voted on patch set 3 CR +1 10/10/19, 13:01

  10. Jörg Bösche commented on patch set 3 CR -1 10/11/19, 07:44

    AbstractItemProvider.php:1005 Unresolved

    I think that at this point still the "sortBy" case is missing. Although the documentation tells us that the combination of "sortBy" and "default_sortby" may not exist, we just consider the "default_sortby". What happens if we have neither an "OrderBy" in the "foreign_table_where" nor a "default_sortby" in the TCA? But a "sortby" => "sorting" exists? IMO we need to implement the "sortBy" case, if the "ORDERBY" and "default_sortby" is not set.

    AbstractItemProvider.php:1008 Unresolved

    The first key will return "null" if empty. It might be better to check "$orderByClause[0] !== null" instead of using empty().
  11. Oliver Klee updated the commit message in patch set 4 10/11/19, 10:37

  12. TYPO3com voted on patch set 4 V -1 10/11/19, 10:51 Completed build in 13m 38s on Fri, 11 Oct, 10:51 AM Test Summary: 1 of 48341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37248

  13. TYPO3com voted on patch set 4 V +1 10/11/19, 11:28 Completed build in 12m 01s on Fri, 11 Oct, 11:28 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37250

  14. Tobi Kretschmann voted on patch set 4 CR +1 10/16/19, 06:58

  15. Jörg Bösche voted on patch set 4 CR +1 01/15/20, 07:29

  16. Felix P. voted on patch set 4 CR +1 01/15/20, 08:36

  17. Sascha Rademacher voted on patch set 4 CR +1 01/15/20, 08:52

  18. Tobi Kretschmann voted on patch set 4 V +1 01/15/20, 08:57

  19. Sascha Rademacher voted on patch set 4 V +1 01/15/20, 09:06

  20. Jörg Bösche voted on patch set 4 V +1 01/15/20, 09:08

  21. Felix P. voted on patch set 4 V +1 01/15/20, 10:08

  22. Steffen Frese voted on patch set 4 V +1 CR +1 01/15/20, 12:50

  23. Tobi Kretschmann voted on patch set 4 V +2 CR +2 01/15/20, 13:34

  24. Tobi Kretschmann merged patch set 5 01/15/20, 13:35