Review main Merged

61475[TASK] Cleanup order by clause in TCA select fields

Christoph Lehmann CR +2 V +2 Normal +14 −45 updated 08/19/19, 20:17

Commit message

This is a follow up of #88933 and removes all order by clauses
since the default_sortby of a table is respected.

It also changes/unifies default sorting of sys_language and
sys_category to title.

Every system table now as single configuration directive for
the sorting of its records: default_sortby

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 38

Show 18 more files

Review log 811

  1. Christoph Lehmann uploaded patch set 1 08/07/19, 23:39

  2. TYPO3com voted on patch set 1 V +1 08/07/19, 23:50 Completed build in 11m 06s on Wed, 7 Aug, 11:50 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35636

  3. Mathias Brodala commented on patch set 1 CR -1 08/08/19, 07:08

    Unresolved

    Since this changes the sorting of some records this should not be backported to v9. Some will see this as breaking change.
  4. Christoph Lehmann updated the commit message in patch set 2 08/08/19, 12:08

  5. TYPO3com voted on patch set 2 V +1 08/08/19, 12:27 Completed build in 18m 15s on Thu, 8 Aug, 12:26 PM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35655

  6. Georg Ringer commented on patch set 2 CR -1 08/12/19, 19:14

    be_groups.php:55 Unresolved

    why removing the pid=0 constraint?
  7. Christoph Lehmann commented on patch set 3 08/13/19, 07:57

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V +1 08/13/19, 08:10 Completed build in 12m 19s on Tue, 13 Aug, 08:10 AM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35686

  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/19/19, 15:46

  10. Georg Ringer voted on patch set 3 V +2 CR +2 08/19/19, 20:17

  11. Georg Ringer merged patch set 4 08/19/19, 20:17