Review main Merged

61478[BUGFIX] Ensure test environment is bootstrapped for cache backend tests

Andreas Kienast CR +2 V +2 Easy +4 −5 updated 08/09/19, 11:41

Commit message

The cache backends tests need a bootstrapped test environment, since vital
parts are not booted at all, e.g. the Environment is undefined.

For this reason, the parent `setUp()` method is now called, albeit this
was not required previously.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 89

  1. Andreas Kienast uploaded patch set 1 08/08/19, 11:34

  2. Andreas Kienast updated the commit message in patch set 2 08/08/19, 11:35

  3. Mathias Brodala commented on patch set 2 08/08/19, 11:36

    MemcachedBackendTest.php:33 Unresolved

    This should be dropped now.

    RedisBackendTest.php:40 Unresolved

    Same here.
  4. Andreas Kienast uploaded patch set 3 08/08/19, 11:38

  5. TYPO3com voted on patch set 3 V +1 08/08/19, 11:52 Completed build in 13m 25s on Thu, 8 Aug, 11:52 AM Test Summary: 47170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35652

  6. Mathias Brodala voted on patch set 3 CR +1 08/08/19, 12:43

  7. Mathias Brodala voted on patch set 3 V +1 08/08/19, 12:51

  8. Frank Nägler voted on patch set 3 V +2 CR +2 08/09/19, 11:41

  9. Frank Nägler merged patch set 4 08/09/19, 11:41