Review main Merged

61479[BUGFIX] Use calling class name for logger initialization

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 08/08/19, 15:17

Commit message

Static class binding via `static::class` leads to the correct class name
in inherited classes.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Susi Moog +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Anja Leichsenring uploaded patch set 1 08/08/19, 12:05

  2. Markus Klein commented on patch set 1 08/08/19, 12:08

    AbstractBackend.php:83 Unresolved

    static::class is possible too, and will be evaluated on compile time rather than during runtime
  3. Andreas Kienast uploaded patch set 2 08/08/19, 12:13

  4. TYPO3com voted on patch set 1 V +1 08/08/19, 12:21 Completed build in 15m 48s on Thu, 8 Aug, 12:21 PM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35654

  5. Markus Klein voted on patch set 2 V +1 CR +1 08/08/19, 12:22

  6. Susi Moog voted on patch set 2 CR +1 08/08/19, 12:32

  7. TYPO3com voted on patch set 2 V +1 08/08/19, 12:34 Completed build in 14m 34s on Thu, 8 Aug, 12:34 PM Test Summary: 47174 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35656

  8. Helmut Hummel voted on patch set 2 CR +1 08/08/19, 12:43

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 08/08/19, 15:17

  10. Andreas Kienast merged patch set 3 08/08/19, 15:17