Review main Merged

61480[BUGFIX] Set parent uid in newly created IRRE child record

Chris Müller CR +2 V +2 Easy +43 −0 updated 02/17/20, 22:24

Commit message

When creating a new IRRE child element the uid of the parent element
was not set. This is a problem when you use an itemsProcFunc for a
select column which relies on the parent's element uid to show
according values. With the parent uid you can query the stored values.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • Anja Leichsenring +1
    • Henning Liebe +1
    • Felix P. +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 3144

Show 1119 earlier messages
  1. Chris Müller uploaded patch set 1 08/08/19, 21:22

  2. TYPO3com voted on patch set 1 V -1 08/08/19, 21:30 Completed build in 08m 15s on Thu, 8 Aug, 09:30 PM Test Summary: 78 of 47543 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35659

  3. Daniel Windloff commented on patch set 1 08/09/19, 13:41

    DatabaseRowInitializeNew.php:240

    Are you sure about this array element? The inlineParentUid is a string by default. It could be an uid (integer) or a NEW123 string for new created parent data.
  4. Chris Müller commented on patch set 1 08/10/19, 21:50

    > Patch Set 1: > > (1 comment)

    DatabaseRowInitializeNew.php:240 Reply Unresolved

    Yes, you are right, I'll provide a new patch. Thanks for the hint.
  5. Chris Müller uploaded patch set 2 08/10/19, 22:13

  6. TYPO3com voted on patch set 2 V -1 08/10/19, 22:24 Completed build in 10m 47s on Sat, 10 Aug, 10:24 PM Test Summary: 77 of 47539 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35666

  7. Andreas Kienast rebased onto patch set 3 08/12/19, 17:52

  8. TYPO3com voted on patch set 3 V +1 08/12/19, 18:22 Completed build in 24m 18s on Mon, 12 Aug, 06:22 PM Test Summary: 47180 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35680

  9. Chris Müller uploaded patch set 4 08/12/19, 21:24

  10. TYPO3com voted on patch set 4 V +1 08/12/19, 21:34 Completed build in 09m 45s on Mon, 12 Aug, 09:34 PM Test Summary: 47180 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35684

  11. Chris Müller rebased onto patch set 5 10/04/19, 08:52

  12. TYPO3com voted on patch set 5 V +1 10/04/19, 09:02 Completed build in 09m 59s on Fri, 4 Oct, 09:02 AM Test Summary: 47763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37036

  13. Christoph Lehmann commented on patch set 5 V +1 CR +1 10/04/19, 10:21

    Tested and it works as expected.
  14. Julian Geils voted on patch set 5 V +1 CR +1 10/09/19, 07:52

  15. Chris Müller rebased onto patch set 6 10/25/19, 16:26

  16. TYPO3com voted on patch set 6 V -1 10/25/19, 16:26 Completed build in 12s on Fri, 25 Oct, 04:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37713

  17. Chris Müller uploaded patch set 7 10/25/19, 16:53

  18. TYPO3com voted on patch set 7 V -1 10/25/19, 17:04 Completed build in 11m 23s on Fri, 25 Oct, 05:04 PM Test Summary: 1 of 48422 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37716

  19. TYPO3com voted on patch set 7 V +1 10/25/19, 17:08 Completed build in 26m 39s on Fri, 25 Oct, 05:08 PM Test Summary: 48063 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37716

  1. Alexander Stehlik voted on patch set 7 CR +1 10/27/19, 11:00

  2. Oli Bartsch commented on patch set 7 10/28/19, 17:00

    DatabaseRowInitializeNew.php:236

    This will trigger `Notice: Undefined index: isInlineChild` if it doesn't exist. Maybe use `isset` like you did at the next one.
  3. Alexander Stehlik commented on patch set 7 10/28/19, 17:40

    DatabaseRowInitializeNew.php:236 Reply

    As far as I can see the isInlineChild is always defined because it is initialized in the default array build by FormDataCompiler::initializeResultArray().
  4. Oli Bartsch commented on patch set 7 10/28/19, 18:16

    DatabaseRowInitializeNew.php:236 Reply

    Ok, but this doesn’t invalidate the fact, that the check like it’s now will trigger a Notice if it doesn’t exist. So either trust for existence (and simply remove the check?) or just use ‘isset’ to ensure no Notice will be triggered at all.
  5. Chris Müller uploaded patch set 8 11/04/19, 13:36

  6. TYPO3com voted on patch set 8 V -1 11/04/19, 13:46 Completed build in 09m 54s on Mon, 4 Nov, 01:46 PM Test Summary: 1 of 48442 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37973

  7. TYPO3com voted on patch set 8 V +1 11/04/19, 16:58 Completed build in 11m 25s on Mon, 4 Nov, 04:58 PM Test Summary: 48127 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37989

  8. Chris Müller commented on patch set 8 11/04/19, 17:53

    DatabaseRowInitializeNew.php:236 Reply

    Ack
  9. Alexander Stehlik voted on patch set 8 CR +1 11/04/19, 18:07

  10. Oli Bartsch commented on patch set 8 11/04/19, 19:55

    DatabaseRowInitializeNew.php:228

    Please don't what should be done but what the function actually does - or at least tries to do. So my suggestion would be something like "Set the parent uid of inline relations created via ajax to the corresponding `foreign_field` field".

    DatabaseRowInitializeNew.php:245

    Just a suggestion. You could move this to line 237 and also treat it with null coalescing as you did for `$result['isInlineChild']` and check also just with `!$parentField`. This will reduce at least to lines of code. Anyway, I would remove the empty line (246) if you dont want to assign the variable befor the `if`.
  11. Chris Müller uploaded patch set 9 11/08/19, 10:48

  12. Chris Müller commented on patch set 9 11/08/19, 10:49

    DatabaseRowInitializeNew.php:228 Reply

    Done

    DatabaseRowInitializeNew.php:245 Reply

    Done
  13. TYPO3com voted on patch set 9 V -1 11/08/19, 11:09 Completed build in 11m 04s on Fri, 8 Nov, 11:09 AM Test Summary: 44807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38103

  14. TYPO3com commented on patch set 9 11/08/19, 11:19 Completed build in 04m 18s on Fri, 8 Nov, 11:19 AM Test Summary: 41308 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38106

  15. TYPO3com voted on patch set 9 V +1 11/08/19, 13:26 Completed build in 10m 49s on Fri, 8 Nov, 01:26 PM Test Summary: 48151 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38113

  16. Oli Bartsch voted on patch set 9 CR +1 11/08/19, 13:55

  17. Benni Mack commented on patch set 9 11/08/19, 14:07

    thanks a bunch. looks a lot like fixing the same issue - but having a different appraoch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/54598 Have to find out which makes more sense (captures more problems)!
  18. Tobi Kretschmann voted on patch set 9 CR +1 11/26/19, 16:20

  19. Henning Liebe voted on patch set 9 CR +1 01/14/20, 11:51

  20. Sascha Rademacher voted on patch set 9 CR +1 01/15/20, 12:55

  21. Felix P. voted on patch set 9 CR +1 01/15/20, 13:11

  22. Jörg Bösche voted on patch set 9 CR +1 01/17/20, 13:51

  23. Anja Leichsenring voted on patch set 9 V +1 CR +1 02/17/20, 22:04

  24. Benni Mack voted on patch set 9 V +2 CR +2 02/17/20, 22:24

  25. Benni Mack merged patch set 10 02/17/20, 22:24