61480[BUGFIX] Set parent uid in newly created IRRE child record
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Sascha Rademacher +1
- Tobi Kretschmann +1
- Anja Leichsenring +1
- Henning Liebe +1
- Felix P. +1
- Jörg Bösche +1
-
Verified V +2 Done
- Benni Mack +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 3144
Show 1119 earlier messages
-
Chris Müller uploaded patch set 1 08/08/19, 21:22
-
TYPO3com voted on patch set 1 V -1 08/08/19, 21:30 Completed build in 08m 15s on Thu, 8 Aug, 09:30 PM Test Summary: 78 of 47543 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35659
-
Daniel Windloff commented on patch set 1 08/09/19, 13:41
-
Chris Müller commented on patch set 1 08/10/19, 21:50
> Patch Set 1: > > (1 comment)DatabaseRowInitializeNew.php:240Reply UnresolvedYes, you are right, I'll provide a new patch. Thanks for the hint. -
Chris Müller uploaded patch set 2 08/10/19, 22:13
-
TYPO3com voted on patch set 2 V -1 08/10/19, 22:24 Completed build in 10m 47s on Sat, 10 Aug, 10:24 PM Test Summary: 77 of 47539 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35666
-
Andreas Kienast rebased onto patch set 3 08/12/19, 17:52
-
TYPO3com voted on patch set 3 V +1 08/12/19, 18:22 Completed build in 24m 18s on Mon, 12 Aug, 06:22 PM Test Summary: 47180 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35680
-
Chris Müller uploaded patch set 4 08/12/19, 21:24
-
TYPO3com voted on patch set 4 V +1 08/12/19, 21:34 Completed build in 09m 45s on Mon, 12 Aug, 09:34 PM Test Summary: 47180 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35684
-
Chris Müller rebased onto patch set 5 10/04/19, 08:52
-
TYPO3com voted on patch set 5 V +1 10/04/19, 09:02 Completed build in 09m 59s on Fri, 4 Oct, 09:02 AM Test Summary: 47763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37036
-
Christoph Lehmann commented on patch set 5 V +1 CR +1 10/04/19, 10:21
Tested and it works as expected. -
Julian Geils voted on patch set 5 V +1 CR +1 10/09/19, 07:52
-
Chris Müller rebased onto patch set 6 10/25/19, 16:26
-
TYPO3com voted on patch set 6 V -1 10/25/19, 16:26 Completed build in 12s on Fri, 25 Oct, 04:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37713
-
Chris Müller uploaded patch set 7 10/25/19, 16:53
-
TYPO3com voted on patch set 7 V -1 10/25/19, 17:04 Completed build in 11m 23s on Fri, 25 Oct, 05:04 PM Test Summary: 1 of 48422 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37716
-
TYPO3com voted on patch set 7 V +1 10/25/19, 17:08 Completed build in 26m 39s on Fri, 25 Oct, 05:08 PM Test Summary: 48063 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37716
-
Alexander Stehlik voted on patch set 7 CR +1 10/27/19, 11:00
-
Oli Bartsch commented on patch set 7 10/28/19, 17:00
DatabaseRowInitializeNew.php:236This will trigger `Notice: Undefined index: isInlineChild` if it doesn't exist. Maybe use `isset` like you did at the next one. -
Alexander Stehlik commented on patch set 7 10/28/19, 17:40
DatabaseRowInitializeNew.php:236ReplyAs far as I can see the isInlineChild is always defined because it is initialized in the default array build by FormDataCompiler::initializeResultArray(). -
Oli Bartsch commented on patch set 7 10/28/19, 18:16
DatabaseRowInitializeNew.php:236ReplyOk, but this doesn’t invalidate the fact, that the check like it’s now will trigger a Notice if it doesn’t exist. So either trust for existence (and simply remove the check?) or just use ‘isset’ to ensure no Notice will be triggered at all. -
Chris Müller uploaded patch set 8 11/04/19, 13:36
-
TYPO3com voted on patch set 8 V -1 11/04/19, 13:46 Completed build in 09m 54s on Mon, 4 Nov, 01:46 PM Test Summary: 1 of 48442 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37973
-
TYPO3com voted on patch set 8 V +1 11/04/19, 16:58 Completed build in 11m 25s on Mon, 4 Nov, 04:58 PM Test Summary: 48127 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37989
-
Chris Müller commented on patch set 8 11/04/19, 17:53
DatabaseRowInitializeNew.php:236ReplyAck -
Alexander Stehlik voted on patch set 8 CR +1 11/04/19, 18:07
-
Oli Bartsch commented on patch set 8 11/04/19, 19:55
DatabaseRowInitializeNew.php:228Please don't what should be done but what the function actually does - or at least tries to do. So my suggestion would be something like "Set the parent uid of inline relations created via ajax to the corresponding `foreign_field` field".DatabaseRowInitializeNew.php:245Just a suggestion. You could move this to line 237 and also treat it with null coalescing as you did for `$result['isInlineChild']` and check also just with `!$parentField`. This will reduce at least to lines of code. Anyway, I would remove the empty line (246) if you dont want to assign the variable befor the `if`. -
Chris Müller uploaded patch set 9 11/08/19, 10:48
-
Chris Müller commented on patch set 9 11/08/19, 10:49
DatabaseRowInitializeNew.php:228ReplyDoneDatabaseRowInitializeNew.php:245ReplyDone -
TYPO3com voted on patch set 9 V -1 11/08/19, 11:09 Completed build in 11m 04s on Fri, 8 Nov, 11:09 AM Test Summary: 44807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38103
-
TYPO3com commented on patch set 9 11/08/19, 11:19 Completed build in 04m 18s on Fri, 8 Nov, 11:19 AM Test Summary: 41308 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38106
-
TYPO3com voted on patch set 9 V +1 11/08/19, 13:26 Completed build in 10m 49s on Fri, 8 Nov, 01:26 PM Test Summary: 48151 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38113
-
Oli Bartsch voted on patch set 9 CR +1 11/08/19, 13:55
-
Benni Mack commented on patch set 9 11/08/19, 14:07
thanks a bunch. looks a lot like fixing the same issue - but having a different appraoch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/54598 Have to find out which makes more sense (captures more problems)! -
Tobi Kretschmann voted on patch set 9 CR +1 11/26/19, 16:20
-
Henning Liebe voted on patch set 9 CR +1 01/14/20, 11:51
-
Sascha Rademacher voted on patch set 9 CR +1 01/15/20, 12:55
-
Felix P. voted on patch set 9 CR +1 01/15/20, 13:11
-
Jörg Bösche voted on patch set 9 CR +1 01/17/20, 13:51
-
Anja Leichsenring voted on patch set 9 V +1 CR +1 02/17/20, 22:04
-
Benni Mack voted on patch set 9 V +2 CR +2 02/17/20, 22:24
-
Benni Mack merged patch set 10 02/17/20, 22:24
DatabaseRowInitializeNew.php:240