Review main Merged

61481[BUGFIX] Render FlashMessages at ClearCache

Guido Schmechel CR +2 V +2 Easy +15 −8 updated 10/18/19, 09:37

Commit message

Custom Clear Cache implementations can provide their own summary of results.
The content of a JSON response can send a title and message to be displayed
as a Flash message. If an error occurs, a global error message is displayed.

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Sascha Rademacher +1
    • Jörg Bösche +1
    • Andreas Kienast +1
    • Henning Liebe +1
    • Felix P. +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Sascha Rademacher +1
    • Jörg Bösche +1
    • Andreas Kienast +1
    • Henning Liebe +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1927

Show 12 earlier messages
  1. Guido Schmechel uploaded patch set 1 08/08/19, 22:50

  2. TYPO3com voted on patch set 1 V -1 08/08/19, 22:58 Completed build in 07m 53s on Thu, 8 Aug, 10:58 PM Test Summary: 77 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35660

  1. Guido Schmechel commented on patch set 1 08/11/19, 08:25

    To clarify: - Should we now also send a flash message with the normal ClearCache actions from the Core? (I would like it) - Is it a Bugfix or a Feature? Possible breaking: An empty JSONResponse has not yet generated any feedback. Now it would come to an error message "Oops an error occured". Because of the "error part"
  2. Guido Schmechel updated the commit message in patch set 2 08/17/19, 21:30

  3. TYPO3com voted on patch set 2 V +1 08/17/19, 21:40 Completed build in 09m 52s on Sat, 17 Aug, 09:40 PM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35728

  4. Anja Leichsenring uploaded patch set 3 09/24/19, 08:26

  5. TYPO3com voted on patch set 3 V +1 09/24/19, 08:35 Completed build in 08m 52s on Tue, 24 Sep, 08:35 AM Test Summary: 47783 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36721

  6. Georg Ringer commented on patch set 3 CR -1 09/24/19, 09:01

    please add a description as well
  7. Anja Leichsenring updated the commit message in patch set 4 09/25/19, 15:09

  8. TYPO3com voted on patch set 4 V -1 09/25/19, 15:31 Completed build in 11m 55s on Wed, 25 Sep, 03:31 PM Test Summary: 1 of 48107 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36820

  9. TYPO3com voted on patch set 4 V +1 09/25/19, 17:07 Completed build in 1h 59m 12s on Wed, 25 Sep, 05:07 PM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36820

  10. Georg Ringer commented on patch set 4 CR -1 09/25/19, 19:25

    the commit msg is kind of not understandable, sorry for nitpicking
  11. Jörg Bösche updated the commit message in patch set 5 10/08/19, 13:27

  12. TYPO3com voted on patch set 5 V -1 10/08/19, 13:49 Completed build in 21m 26s on Tue, 8 Oct, 01:49 PM Test Summary: 1 of 48078 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37144

  13. TYPO3com voted on patch set 5 V +1 10/08/19, 14:24 Completed build in 1h 17m 23s on Tue, 8 Oct, 02:24 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37144

  14. Andreas Kienast commented on patch set 5 10/08/19, 14:25

    ClearCacheMenu.ts:79 Unresolved

    I'd move the icon replacement into a `complete` callback. This is called right after `success` and `error`.
  15. Andreas Kienast uploaded patch set 6 10/08/19, 14:28

  16. TYPO3com voted on patch set 6 V +1 10/08/19, 14:36 Completed build in 08m 08s on Tue, 8 Oct, 02:36 PM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37146

  17. Andreas Kienast voted on patch set 6 V +1 CR +1 10/08/19, 14:37

  18. Sascha Rademacher voted on patch set 6 V +1 CR +1 10/09/19, 08:07

  19. Jörg Bösche voted on patch set 6 V +1 CR +1 10/09/19, 08:51

  20. Henning Liebe voted on patch set 6 V +1 CR +1 10/09/19, 10:17

  21. Felix P. voted on patch set 6 CR +1 10/09/19, 10:49

  22. Tobi Kretschmann voted on patch set 6 V +2 CR +2 10/15/19, 12:26

  23. Tobi Kretschmann merged patch set 7 10/15/19, 12:29

  24. Frank Nägler commented on patch set 7 10/18/19, 09:31

    ClearCacheMenu.ts:79

    post -1 the message is not translatable
  25. Frank Nägler commented on patch set 7 10/18/19, 09:37

    ClearCacheMenu.ts:79 Reply Unresolved

    ok, I just saw, it was also before. so ignore my comment, I create an own issue for this,