Review main Merged

61482[BUGFIX] Ensure manually updated slug is saved correctly

Oli Bartsch CR +2 V +2 Easy +12 −6 updated 08/20/19, 08:46

Commit message

This fixes the bug, that after updating the slug and clicking
the toggle URL button, the slug isn't updated correctly.

Therefore, if the value of the input and read only field differ
after clicking the toggle button, now the updated value
of the input field is written into the read only and hidden field.

Furthermore after recreating the slug, the new value is now also
written into the input field to be present after clicking
the toogle URL button again. Otherwise the recreated slug would be
discarded on save.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jens Ulrich +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jens Ulrich +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 712

  1. Oli Bartsch uploaded patch set 1 08/09/19, 08:48

  2. TYPO3com voted on patch set 1 V -1 08/09/19, 08:59 Completed build in 10m 44s on Fri, 9 Aug, 08:59 AM Test Summary: 77 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35661

  3. TYPO3com commented on patch set 1 08/09/19, 09:07 Completed build in 29m 35s on Fri, 9 Aug, 09:07 AM Test Summary: 77 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35661

  4. Susi Moog rebased onto patch set 2 08/12/19, 18:28

  5. TYPO3com voted on patch set 2 V -1 08/12/19, 18:44 Completed build in 14m 10s on Mon, 12 Aug, 06:44 PM Test Summary: 1 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35681

  6. TYPO3com voted on patch set 2 V +1 08/13/19, 06:47 Completed build in 12h 31m 54s on Tue, 13 Aug, 06:47 AM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35681

  7. Oli Bartsch uploaded patch set 3 08/15/19, 21:00

  8. TYPO3com voted on patch set 3 V +1 08/15/19, 21:10 Completed build in 09m 51s on Thu, 15 Aug, 09:10 PM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35711

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 08/16/19, 06:53

  10. Jens Ulrich voted on patch set 3 V +1 CR +1 08/16/19, 07:27

  11. Andreas Kienast voted on patch set 3 V +2 CR +2 08/20/19, 08:45

  12. Andreas Kienast merged patch set 4 08/20/19, 08:46