Review main Merged

61483[BUGFIX] Increase memory cost of argon2i and force testing mariadb 10.3

Andreas Kienast CR +2 V +2 Easy +11 −11 updated 08/12/19, 17:26

Commit message

Due to security reasons, PHP's default memory_cost of argon2i has been
increased from 16384 to 65536:

  https://bugs.php.net/bug.php?id=78269

We shouldn't lower the factory default, thus this patch alignes the
hashing implementation.

Furthermore, mariadb 10.4 currently crashes with the functional
tests. The patch forces 10.3 for now to make bamboo green again.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1521

  1. Andreas Kienast uploaded patch set 1 08/09/19, 09:14

  2. Susi Moog voted on patch set 1 CR +1 08/09/19, 09:16

  3. Christian Kuhn commented on patch set 1 V -1 08/09/19, 09:22

    will go red in bamboo, tests need adaptions, too.
  4. TYPO3com voted on patch set 1 V -1 08/09/19, 09:22 Completed build in 08m 34s on Fri, 9 Aug, 09:22 AM Test Summary: 77 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35662

  5. Mathias Brodala commented on patch set 1 08/09/19, 09:26

    Argon2iPasswordHash.php:43

    Would it make sense to use "64 << 10" too here? This would increase discovery when looking for this specific value.
  6. Andreas Kienast commented on patch set 1 08/09/19, 09:32

    Argon2iPasswordHash.php:43 Reply Unresolved

    Hmm, that's "just" lowlevel stuff, I'd keep it now as is
  7. Andreas Kienast uploaded patch set 2 08/09/19, 09:33

  8. Christian Kuhn commented on patch set 2 V +1 CR +1 08/09/19, 09:42

    bamboo will still vote -1, but that is a different issue ... i'd suggest to verify the unit (!) tests are now green with this patch set, and already merge that one.
  9. TYPO3com voted on patch set 2 V -1 08/09/19, 09:44 Completed build in 10m 37s on Fri, 9 Aug, 09:44 AM Test Summary: 21 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35663

  10. TYPO3com commented on patch set 2 08/09/19, 11:02 Completed build in 1h 39m 41s on Fri, 9 Aug, 11:02 AM Test Summary: 21 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35663

  11. Jonas Eberle commented on patch set 2 08/09/19, 13:06

    Argon2iPasswordHash.php:38

    I would update that to give a feeling for the new values
  12. TYPO3com commented on patch set 2 08/12/19, 09:44 Completed build in 1h 50m 27s on Mon, 12 Aug, 09:44 AM Test Summary: 21 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35663

  13. Christian Kuhn commented on patch set 2 08/12/19, 17:08

    Argon2iPasswordHash.php:38 Reply

    afaik, increasing memory_cost does not increase cpu time.
  14. Christian Kuhn uploaded patch set 3 08/12/19, 17:12

  15. Christian Kuhn uploaded patch set 4 08/12/19, 17:17

  16. Jonas Eberle commented on patch set 4 08/12/19, 17:21

    Argon2iPasswordHash.php:38 Reply

    Ack
  17. TYPO3com voted on patch set 3 V -1 08/12/19, 17:23 Completed build in 10m 12s on Mon, 12 Aug, 05:23 PM Test Summary: 56 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35674

  18. Christian Kuhn voted on patch set 4 V +1 CR +1 08/12/19, 17:25

  19. TYPO3com voted on patch set 4 V +1 08/12/19, 17:26 Completed build in 08m 51s on Mon, 12 Aug, 05:26 PM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35675

  20. Andreas Kienast voted on patch set 4 V +2 CR +2 08/12/19, 17:26

  21. Andreas Kienast merged patch set 5 08/12/19, 17:26