61483[BUGFIX] Increase memory cost of argon2i and force testing mariadb 10.3
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 5
- Build/testing-docker/bamboo/docker-compose.yml+1 −1
- Build/testing-docker/local/docker-compose.yml+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/Argon2iPasswordHash.php5+2 −2
- typo3/sysext/core/Tests/Unit/Authentication/AuthenticationServiceTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Argon2iPasswordHashTest.php+5 −5
Review log 1521
-
Andreas Kienast uploaded patch set 1 08/09/19, 09:14
-
Susi Moog voted on patch set 1 CR +1 08/09/19, 09:16
-
Christian Kuhn commented on patch set 1 V -1 08/09/19, 09:22
will go red in bamboo, tests need adaptions, too. -
TYPO3com voted on patch set 1 V -1 08/09/19, 09:22 Completed build in 08m 34s on Fri, 9 Aug, 09:22 AM Test Summary: 77 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35662
-
Mathias Brodala commented on patch set 1 08/09/19, 09:26
Argon2iPasswordHash.php:43Would it make sense to use "64 << 10" too here? This would increase discovery when looking for this specific value. -
Andreas Kienast commented on patch set 1 08/09/19, 09:32
Argon2iPasswordHash.php:43Reply UnresolvedHmm, that's "just" lowlevel stuff, I'd keep it now as is -
Andreas Kienast uploaded patch set 2 08/09/19, 09:33
-
Christian Kuhn commented on patch set 2 V +1 CR +1 08/09/19, 09:42
bamboo will still vote -1, but that is a different issue ... i'd suggest to verify the unit (!) tests are now green with this patch set, and already merge that one. -
TYPO3com voted on patch set 2 V -1 08/09/19, 09:44 Completed build in 10m 37s on Fri, 9 Aug, 09:44 AM Test Summary: 21 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35663
-
TYPO3com commented on patch set 2 08/09/19, 11:02 Completed build in 1h 39m 41s on Fri, 9 Aug, 11:02 AM Test Summary: 21 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35663
-
Jonas Eberle commented on patch set 2 08/09/19, 13:06
Argon2iPasswordHash.php:38I would update that to give a feeling for the new values -
TYPO3com commented on patch set 2 08/12/19, 09:44 Completed build in 1h 50m 27s on Mon, 12 Aug, 09:44 AM Test Summary: 21 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35663
-
Christian Kuhn commented on patch set 2 08/12/19, 17:08
Argon2iPasswordHash.php:38Replyafaik, increasing memory_cost does not increase cpu time. -
Christian Kuhn uploaded patch set 3 08/12/19, 17:12
-
Christian Kuhn uploaded patch set 4 08/12/19, 17:17
-
Jonas Eberle commented on patch set 4 08/12/19, 17:21
Argon2iPasswordHash.php:38ReplyAck -
TYPO3com voted on patch set 3 V -1 08/12/19, 17:23 Completed build in 10m 12s on Mon, 12 Aug, 05:23 PM Test Summary: 56 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35674
-
Christian Kuhn voted on patch set 4 V +1 CR +1 08/12/19, 17:25
-
TYPO3com voted on patch set 4 V +1 08/12/19, 17:26 Completed build in 08m 51s on Mon, 12 Aug, 05:26 PM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35675
-
Andreas Kienast voted on patch set 4 V +2 CR +2 08/12/19, 17:26
-
Andreas Kienast merged patch set 5 08/12/19, 17:26