61484[TASK] TcaMigration: Cast/convert TCA array elements to bool, int, float
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 7
- typo3/sysext/core/Classes/Migrations/TcaMigration.php4+58 −1
- typo3/sysext/core/Classes/Migrations/TcaMigrationConfiguration.php14new+307 −0
- typo3/sysext/core/Configuration/TCA/be_groups.php+2 −2
- typo3/sysext/core/Configuration/TCA/be_users.php+4 −4
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+166 −0
- typo3/sysext/lowlevel/Classes/Utility/ArrayBrowser.php+18 −4
- typo3/sysext/seo/Configuration/TCA/Overrides/pages.php+4 −4
Review log 79
-
Daniel Windloff uploaded patch set 1 08/10/19, 06:44
-
TYPO3com voted on patch set 1 V -1 08/10/19, 06:55 Completed build in 11m 13s on Sat, 10 Aug, 06:55 AM Test Summary: 77 of 47555 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35665
-
Mathias Brodala commented on patch set 1 CR -1 08/12/19, 07:10
TcaMigration.php:119This is wrong since settype() changes the value type in place, it does not return the changed value but true/false on success/failure. So basically this would replace everything with a boolean "true"TcaMigrationConfiguration.php:31Should be "getValueTypes()"TcaMigrationConfiguration.php:34This should be "bool"TcaMigrationConfiguration.php:40This should be "int"TcaMigrationConfiguration.php:64TypoTcaMigrationConfiguration.php:67This should be "float"TcaMigrationConfiguration.php:292This method does not do what it advertises. Also I'm having a hard time understanding this method name. -
Daniel Windloff uploaded patch set 2 08/13/19, 05:24
-
Daniel Windloff commented on patch set 2 08/13/19, 05:32
Thx for your review. I also add a little adjustment to the ArrayBrowser.TcaMigration.php:57ReplyDoneTcaMigration.php:119ReplyOh, right. It seems, that I was somehow inattentive there ;)TcaMigrationConfiguration.php:31ReplyDoneTcaMigrationConfiguration.php:34ReplyI'd like to use php:gettype() to get the current type of the TCA value. Then I'd like to compare that value with the expeced one. That is why I used boolean instead of bool, integer insted of int and double instead of float.TcaMigrationConfiguration.php:40ReplyAckTcaMigrationConfiguration.php:64ReplyDoneTcaMigrationConfiguration.php:67ReplyAckTcaMigrationConfiguration.php:292Reply UnresolvedI was unsure how to name it -
TYPO3com voted on patch set 2 V +1 08/13/19, 05:36 Completed build in 12m 07s on Tue, 13 Aug, 05:36 AM Test Summary: 47196 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35685
-
Oliver Klee commented on patch set 2 08/13/19, 09:38
TcaMigrationConfiguration.php:29UnresolvedWe can make this even more specific (in the annotation, not the return type annotation): string[]TcaMigrationConfiguration.php:290UnresolvedHere as well: string[] -
Susi Moog commented on patch set 2 10/25/19, 21:50
Can you rebase / resolve the merge conflicts please? -
Benni Mack abandoned the change 03/07/20, 14:00
I'll abandon this change for the time being, as there was no movement in the past 5 months.
TcaMigration.php:57