Review main Merged

61490[BUGFIX] Respect readOnly for inline relation

Georg Ringer CR +2 V +2 Easy +20 −5 updated 09/05/19, 11:12

Commit message

If a TCA field is set to readOnly=true and is using the type "inline",
all buttons are now hidden and the fields of the relation are set to
readOnly as well.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Torben Hansen +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1013

  1. Georg Ringer uploaded patch set 1 08/12/19, 18:59

  2. Georg Ringer commented on patch set 1 08/12/19, 19:00

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 08/12/19, 19:10 Completed build in 11m 08s on Mon, 12 Aug, 07:10 PM Test Summary: 1 of 47535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35682

  4. TYPO3com voted on patch set 1 V +1 08/12/19, 19:50 Completed build in 1h 02m 31s on Mon, 12 Aug, 07:50 PM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35682

  5. Sebastian Michaelsen voted on patch set 1 CR +1 08/13/19, 06:27

  6. Richard Haeser voted on patch set 1 CR +1 08/13/19, 06:35

  7. Torben Hansen commented on patch set 1 V -1 CR +1 08/13/19, 18:06

    I tested the patch with the inline elements in ext:styleguide. Obviously, it does not work for tx_styleguide_inline_usecombination and tx_styleguide_inline_usecombinationbox. For those two types, the inline child fields are still editable. TBO I do not know, if this is intended behavior or not for inline childs with useCombination => true
  8. Georg Ringer uploaded patch set 2 08/14/19, 04:40

  9. TYPO3com voted on patch set 2 V +1 08/14/19, 04:53 Completed build in 12m 50s on Wed, 14 Aug, 04:53 AM Test Summary: 47174 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35691

  10. Oliver Klee commented on patch set 2 08/14/19, 08:52

    Can we have (regression) tests for this?
  11. Torben Hansen voted on patch set 2 V +1 CR +1 08/14/19, 17:21

  12. Richard Haeser voted on patch set 2 V +2 CR +2 09/05/19, 11:12

  13. Richard Haeser merged patch set 3 09/05/19, 11:12