Review 9.5 Merged

61497[BUGFIX] Process t3:// link resources correctly

Oliver Hader CR +2 V +2 Hard +288 −13 updated 08/15/19, 13:55

Commit message

* t3://email?email=oliver@typo3.org (be greedy about missing mailto:)
* t3://file?identifier=1:/logo.png (not implemented since no integer)

Besides that according test cases are added in order to ensure the
basic behavior of link handling in a TypoScript frontend rendering
scenario using t3:// link resources.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1320

  1. Oliver Hader uploaded patch set 1 08/14/19, 17:39

  2. TYPO3com voted on patch set 1 V -1 08/14/19, 17:39 Completed build in 10s on Wed, 14 Aug, 05:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1012

  3. Oliver Hader voted on patch set 1 CR -2 08/14/19, 17:48

  4. Oliver Hader uploaded patch set 2 08/14/19, 18:01

  5. TYPO3com voted on patch set 2 V -1 08/14/19, 18:14 Completed build in 13m 04s on Wed, 14 Aug, 06:14 PM Test Summary: 6 of 51036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1013

  6. Oliver Hader uploaded patch set 3 08/14/19, 18:22

  7. Oliver Hader uploaded patch set 4 08/14/19, 18:34

  8. TYPO3com voted on patch set 3 V +1 08/14/19, 18:36 Completed build in 13m 45s on Wed, 14 Aug, 06:36 PM Test Summary: 50568 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1014

  9. Oliver Hader voted on patch set 4 CR 0 08/14/19, 18:39

  10. TYPO3com voted on patch set 4 V +1 08/14/19, 18:47 Completed build in 12m 53s on Wed, 14 Aug, 06:47 PM Test Summary: 50565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1015

  11. Oliver Hader commented on patch set 4 08/15/19, 08:08

    This change is ready for review.
  12. Oliver Hader commented on patch set 5 08/15/19, 08:57

    Published edit on patch set 4.
  13. TYPO3com voted on patch set 5 V +1 08/15/19, 09:14 Completed build in 12m 41s on Thu, 15 Aug, 09:14 AM Test Summary: 50568 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1017

  14. Oliver Hader commented on patch set 5 CR -1 08/15/19, 11:52

  15. Frank Nägler uploaded patch set 6 08/15/19, 11:58

  16. Oliver Hader commented on patch set 7 08/15/19, 12:01

    Published edit on patch set 6.
  17. TYPO3com voted on patch set 6 V +1 08/15/19, 12:11 Completed build in 12m 44s on Thu, 15 Aug, 12:11 PM Test Summary: 50568 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1018

  18. TYPO3com voted on patch set 7 V +1 08/15/19, 12:34 Completed build in 31m 46s on Thu, 15 Aug, 12:34 PM Test Summary: 50568 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1019

  19. Frank Nägler voted on patch set 7 V +2 CR +2 08/15/19, 13:48

  20. Frank Nägler merged patch set 8 08/15/19, 13:55