Review main Merged

61498[BUGFIX] Process t3:// link resources correctly

Oliver Hader CR +2 V +2 Hard +288 −13 updated 08/15/19, 11:57

Commit message

* t3://email?email=oliver@typo3.org (be greedy about missing mailto:)
* t3://file?identifier=1:/logo.png (not implemented since no integer)

Besides that according test cases are added in order to ensure the
basic behavior of link handling in a TypoScript frontend rendering
scenario using t3:// link resources.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1827

Show 12 earlier messages
  1. Oliver Hader uploaded patch set 1 08/14/19, 17:43

  2. TYPO3com voted on patch set 1 V -1 08/14/19, 17:44 Completed build in 11s on Wed, 14 Aug, 05:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35698

  1. Oliver Hader uploaded patch set 2 08/14/19, 17:47

  2. TYPO3com voted on patch set 2 V -1 08/14/19, 17:54 Completed build in 06m 59s on Wed, 14 Aug, 05:54 PM Test Summary: 4 of 40095 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35699

  3. TYPO3com commented on patch set 2 08/14/19, 17:59 Completed build in 18m 10s on Wed, 14 Aug, 05:59 PM Test Summary: 4 of 40095 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35699

  4. Oliver Hader uploaded patch set 3 08/14/19, 18:07

  5. Oliver Hader uploaded patch set 4 08/14/19, 18:17

  6. TYPO3com voted on patch set 3 V -1 08/14/19, 18:17 Completed build in 10m 30s on Wed, 14 Aug, 06:17 PM Test Summary: 28 of 47570 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35700

  7. Oliver Hader voted on patch set 4 CR -2 08/14/19, 18:22

  8. TYPO3com voted on patch set 4 V -1 08/14/19, 18:29 Completed build in 11m 36s on Wed, 14 Aug, 06:29 PM Test Summary: 27 of 47570 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35701

  9. Oliver Hader uploaded patch set 5 08/14/19, 18:34

  10. Oliver Hader voted on patch set 5 CR 0 08/14/19, 18:40

  11. TYPO3com voted on patch set 5 V +1 08/14/19, 18:48 Completed build in 13m 32s on Wed, 14 Aug, 06:48 PM Test Summary: 47208 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35702

  12. Oliver Hader commented on patch set 5 08/15/19, 06:50

    This change is ready for review.
  13. Andreas Kienast voted on patch set 5 V +1 CR +1 08/15/19, 08:15

  14. Oliver Hader commented on patch set 6 08/15/19, 08:54

    Published edit on patch set 5.
  15. Oliver Hader commented on patch set 7 08/15/19, 08:55

    Published edit on patch set 6.
  16. TYPO3com voted on patch set 7 V +1 08/15/19, 09:07 Completed build in 11m 22s on Thu, 15 Aug, 09:07 AM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35704

  17. TYPO3com voted on patch set 6 V -1 08/15/19, 09:07 Completed build in 12m 30s on Thu, 15 Aug, 09:07 AM Test Summary: 6 of 47570 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35703

  18. Frank Nägler voted on patch set 7 V +1 CR +1 08/15/19, 09:08

  19. Oliver Klee commented on patch set 7 08/15/19, 10:10

    EmailLinkHandlerTest.php:39 Unresolved

    Please let's use the example.com domain (which is one of the official domains for testing purposes) for all domains (at least in new code) so that the poor souls at love.com don't receive and additional spam.
  20. Frank Nägler commented on patch set 8 08/15/19, 11:24

    Published edit on patch set 7.
  21. TYPO3com voted on patch set 8 V +1 08/15/19, 11:35 Completed build in 11m 12s on Thu, 15 Aug, 11:35 AM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35705

  22. Andreas Kienast voted on patch set 8 V +1 CR +1 08/15/19, 11:39

  23. Oliver Klee voted on patch set 8 CR +1 08/15/19, 11:44

  24. Frank Nägler voted on patch set 8 V +2 CR +2 08/15/19, 11:57

  25. Frank Nägler merged patch set 9 08/15/19, 11:57