Review main Merged

61499[BUGFIX] Avoid double slash in cache directory

Helmut Hummel CR +2 V +2 Easy +9 −17 updated 08/19/19, 20:58

Commit message

When configuring a different cache directory,
the setter is called in SimpleFileBackend, which tries
to add the cache identifier as last directory name.

At this time however the cache identifier is still empty
and the full directory path is composed in setCache anyway.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Helmut Hummel uploaded patch set 1 08/15/19, 13:29

  2. Helmut Hummel uploaded patch set 2 08/15/19, 13:33

  3. TYPO3com voted on patch set 1 V -1 08/15/19, 13:41 Completed build in 11m 54s on Thu, 15 Aug, 01:41 PM Test Summary: 32 of 47570 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35707

  4. TYPO3com voted on patch set 2 V +1 08/15/19, 13:44 Completed build in 10m 55s on Thu, 15 Aug, 01:44 PM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35708

  5. Oliver Hader commented on patch set 2 08/15/19, 13:52

    SimpleFileBackend.php:174 Unresolved

    Probably the reasoning is correct, however I'm not 100% sure whether there are other processings... What about having `$this->temporaryCacheDirectory = rtrim($documentRoot . $cacheDirectory . $this->cacheIdentifier, '/') . '/';` instead?
  6. Helmut Hummel commented on patch set 2 08/15/19, 15:14

    SimpleFileBackend.php:174 Unresolved

    cacheIdentifier is never set at this point, because the setter is called in the constructor and the cacheIdentifier is set in setCache so I see no point in making auch change
  7. Benni Mack commented on patch set 2 V +1 CR +1 08/19/19, 19:45

    Ran into this exact issue 3 weeks ago. Thanks!
  8. Richard Haeser voted on patch set 2 V +2 CR +2 08/19/19, 20:58

  9. Richard Haeser merged patch set 3 08/19/19, 20:58