Review main Merged

61503[BUGFIX] Generate valid export url for files in filelist

Andreas Kienast CR +2 V +2 Easy +3 −2 updated 09/24/19, 09:07

Commit message

Since FAL is in place, the export url for files generated in the
clipboard is broken as it takes the full file identifier. Previously it
took the physical file path, the code was never adjusted to be
compatible with FAL.

This patch now resolves the file identifier and generates proper
arguments for export.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Andreas Kienast uploaded patch set 1 08/16/19, 08:07

  2. Andreas Kienast uploaded patch set 2 08/16/19, 08:09

  3. TYPO3com voted on patch set 1 V +1 08/16/19, 08:23 Completed build in 16m 07s on Fri, 16 Aug, 08:23 AM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35714

  4. TYPO3com voted on patch set 2 V +1 08/16/19, 08:27 Completed build in 13m 25s on Fri, 16 Aug, 08:27 AM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35715

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 09/24/19, 07:40

  6. Benni Mack voted on patch set 2 V +2 CR +2 09/24/19, 09:07

  7. Benni Mack merged patch set 3 09/24/19, 09:07