Review main Abandoned

61506[WIP][BUGFIX] Make Persisted*Mapper aspects site-aware

Andreas Kienast CR 0 V 0 Normal +158 −6 updated 09/30/19, 14:49

Commit message

The PersistedAliasMapper und PersistedPatternMapper aspects are now
site-aware which allows a better resolving in case a record with the
same slug is used in several pages. Site-awareness is taken into
consideration when a field responsible for slug generation is configured
as `uniqueInSite`.

TODO:
 - Add tests
 - Check whether building the page tree can be done in a more performant
   way

Review

  • Code review CR 0
  • Verified V 0

Files 6

Review log 59

  1. Andreas Kienast uploaded patch set 1 08/16/19, 12:13

  2. TYPO3com voted on patch set 1 V -1 08/16/19, 12:14 Completed build in 11s on Fri, 16 Aug, 12:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35719

  3. Andreas Kienast uploaded patch set 2 08/16/19, 12:14

  4. TYPO3com voted on patch set 2 V -1 08/16/19, 12:24 Completed build in 10m 33s on Fri, 16 Aug, 12:24 PM Test Summary: 240 of 47570 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35720

  5. Andreas Kienast uploaded patch set 3 08/16/19, 13:25

  6. TYPO3com voted on patch set 3 V -1 08/16/19, 13:36 Completed build in 10m 41s on Fri, 16 Aug, 01:36 PM Test Summary: 121 of 47570 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35721

  7. Andreas Kienast uploaded patch set 4 08/16/19, 13:38

  8. TYPO3com voted on patch set 4 V +1 08/16/19, 13:46 Completed build in 08m 22s on Fri, 16 Aug, 01:46 PM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35722

  9. Andreas Kienast abandoned the change 09/30/19, 14:49