Review main Merged

61509[BUGFIX] RedirectService respects parameters

Guido Schmechel CR +2 V +2 Easy +49 −0 updated 10/21/19, 14:15

Commit message

Respect additional parameters from typolink for redirects.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1418

  1. Guido Schmechel uploaded patch set 1 08/17/19, 21:01

  2. TYPO3com voted on patch set 1 V -1 08/17/19, 21:02 Completed build in 12s on Sat, 17 Aug, 09:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35726

  3. Guido Schmechel uploaded patch set 2 08/17/19, 21:03

  4. TYPO3com voted on patch set 2 V +1 08/17/19, 21:14 Completed build in 10m 40s on Sat, 17 Aug, 09:14 PM Test Summary: 47215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35727

  5. Sascha Rademacher commented on patch set 2 CR -1 10/10/19, 12:32

    RedirectService.php:214

    It does not work for me because $matchedRedirect['keep_query_parameters'] must be set to true for this to work. In my opinion $matchedRedirect has to be extended with "additionalParams" and used later. $matchedRedirect['keep_query_parameters'] option is for incoming url and not for the target url. $matchedRedirect['additionalParams'] could be merged with $configuration['additionalParams'] in $this->getUriFromCustomLinkDetails function.
  6. Sascha Rademacher voted on patch set 2 V -1 10/10/19, 12:32

  7. Guido Schmechel uploaded patch set 3 10/10/19, 19:30

  8. Guido Schmechel commented on patch set 3 10/10/19, 19:31

    RedirectService.php:214 Reply Unresolved

    Yes you're right. The condition affects normal pages as well as URLs. Therefore, the query with this 'keep_query_parameters' option must already take place before. Thanks for the hint!
  9. TYPO3com voted on patch set 3 V -1 10/10/19, 19:40 Completed build in 10m 17s on Thu, 10 Oct, 07:40 PM Test Summary: 4 of 48082 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37232

  10. Guido Schmechel uploaded patch set 4 10/10/19, 20:03

  11. TYPO3com voted on patch set 4 V +1 10/10/19, 20:13 Completed build in 09m 33s on Thu, 10 Oct, 08:13 PM Test Summary: 47986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37233

  12. Sascha Rademacher voted on patch set 4 CR -1 10/11/19, 06:59

  13. Sascha Rademacher wrote 10/11/19, 07:05

    Removed Code-Review-1 by Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
  14. Sascha Rademacher voted on patch set 4 V +1 CR +1 10/11/19, 07:16

  15. Tobi Kretschmann voted on patch set 4 CR +1 10/11/19, 07:34

  16. Tobi Kretschmann voted on patch set 4 V +1 10/11/19, 07:39

  17. Daniel Goerz voted on patch set 4 V +2 CR +2 10/21/19, 14:15

  18. Daniel Goerz merged patch set 5 10/21/19, 14:15